AES callbacks for CFB and OFB

[night1rider]

Adding wiring for AES CFB/OFB callbacks to pass off to hardware.

[github-actions]

retest this please

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• linuxkm-pie
• linuxkm-standard
• stm32-sim-stm32h753

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #10748

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #10748

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

[rizlik]

Hi @night1rider ,
I would love to new cryptocb to have ONLY_AES support for new callbacks from day 1.

[night1rider]

Hi @night1rider , I would love to new cryptocb to have ONLY_AES support for new callbacks from day 1.

Hi @rizlik, I added swdev_aes_cfb/swdev_aes_ofb handlers so the new CFB/OFB callbacks are exercised all the way through under WOLF_CRYPTO_CB_ONLY_AES. I didn't end up needing any aes.c changes. The shim from c5ef06013 that encrypts one block at a time already composes CFB/OFB from the ECB callback under ONLY_AES, so the modes work as soon as the dedicated callbacks exist. swdev just didn't have a CFB/OFB backend yet (it only implemented CBC/CTR/ECB/GCM/CCM), so I added one so it can service those callbacks. Does that match what you had in mind, or were you expecting something on the library side too?

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #10748

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #10748

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅