Prevent UAF on DER objects, reject API in SNI callback#10905
Open
padelsbach wants to merge 1 commit into
Open
Conversation
ef8b88b to
767782b
Compare
767782b to
c432e9e
Compare
|
retest this please |
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a family of UAF due to shared DER buffer between WOLFSSL_CTX and WOLFSSL objects raised in zd 22107.
There are two situations we want to solve:
SSL_CTX_use_certificate_chain_file,SSL_CTX_use_PrivateKey_file,SSL_CTX_use_certificate)Change is to refcount DER objects and disallow several routines from the SNI callback.
Footprint impact:
The following APIs are not allowed during the SNI callback:
Certificate:
Certificate chain:
Private key:
Alt private key (WOLFSSL_DUAL_ALG_CERTS):
The following APIs are not allowed while any session is active since the DH params buffer is public and thus cannot be refcounted without breaking the ABI.
DH:
Testing
Added unit tests.
Checklist