Skip to content

Restrict duplicate netscape certificate type extensions f-10626 - #11236

Open
JacobBarthelmeh wants to merge 1 commit into
wolfSSL:masterfrom
JacobBarthelmeh:netscape
Open

Restrict duplicate netscape certificate type extensions f-10626#11236
JacobBarthelmeh wants to merge 1 commit into
wolfSSL:masterfrom
JacobBarthelmeh:netscape

Conversation

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor

No description provided.

@JacobBarthelmeh JacobBarthelmeh self-assigned this Aug 21, 2026
Copilot AI lite review requested due to automatic review settings August 21, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens X.509 extension parsing by rejecting duplicate occurrences of the Netscape Certificate Type extension, aligning it with existing duplicate-extension detection behavior used for other extensions.

Changes:

  • Added a DecodedCert bitfield (extNetscapeCertTypeSet) to track whether the Netscape Certificate Type extension has already been seen (when not compiled with IGNORE_NETSCAPE_CERT_TYPE).
  • Enforced “no duplicate extension” behavior for NETSCAPE_CT_OID via the existing VERIFY_AND_SET_OID() mechanism in DecodeExtensionType().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
wolfssl/wolfcrypt/asn.h Adds a decode-time “seen” flag for Netscape Cert Type to support duplicate detection.
wolfcrypt/src/asn.c Rejects repeated NETSCAPE_CT_OID by verifying/setting the new “seen” flag before decoding.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m0plus

  • FLASH: .text +28 B (+0.0%, 66,883 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m3

  • FLASH: .text +20 B (+0.0%, 125,671 B / 262,144 B, total: 48% used)

gcc-arm-cortex-m4

  • FLASH: .text +64 B (+0.0%, 204,335 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +64 B (+0.1%, 69,411 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .text +64 B (+0.0%, 185,660 B / 1,048,576 B, total: 18% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .text +64 B (+0.0%, 241,057 B / 262,144 B, total: 92% used)

gcc-arm-cortex-m7

  • FLASH: .text +64 B (+0.0%, 204,335 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m7-tls13

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #11236

Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants