Remove RS Unified Comments experimental toggle - #23170
Merged
Merged
Conversation
…ble sites The RS comments screens now show automatically for any site with an application password, mirroring how RS Posts and Pages work. Removes the Feature.RS_UNIFIED_COMMENTS toggle and its strings; the RS comments UI itself is unchanged. The gate no longer needs a Context, which leaves ActivityLauncherEntryPoint without consumers, so it's deleted too.
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #23170 +/- ##
=======================================
Coverage 37.83% 37.84%
=======================================
Files 2345 2345
Lines 127541 127530 -11
Branches 17717 17715 -2
=======================================
- Hits 48261 48258 -3
+ Misses 75321 75313 -8
Partials 3959 3959 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The comment claimed the legacy comments screens are kept for WP.com-accessed sites, but hasApplicationPassword() has no WP.com check, so Atomic and Jetpack sites that hold an application password do get the rs screens. Only the comment was wrong; the routing is unchanged.
…seWpRs The posts, pages, and comments gates had drifted into three byte-identical copies of the same predicate, coupled only by a comment asking future editors to keep them in sync. One definition means they can't diverge for the same site.
UnifiedCommentsActivity never reads WordPress.SITE - it resolves the site from SelectedSiteRepository, as does the rs list - so the extra was a trap for anyone trying to fix a multi-site bug by changing the caller.
Pins the rs eligibility rule in both directions, including that a WP.com site holding an application password is eligible - the case the old comment got wrong.
Removing RS_UNIFIED_COMMENTS left the enum terminator on the new last entry, where it falsely signals that members follow. The enum has none.
nbradbury
marked this pull request as ready for review
August 3, 2026 17:48
dcalhoun
approved these changes
Aug 3, 2026
dcalhoun
left a comment
dcalhoun
left a comment
Member
There was a problem hiding this comment.
Looks good. The app functioned as expected when I tested a site authenticated with an app password.
Claude flagged an additional conditional related to wordpress-rs comments. I presume this is intentionally excluded from this work, but wanted to note for your consideration.
| * Whether the wordpress-rs screens (posts, pages, comments) should be used for {@code site} | ||
| * instead of the legacy (FluxC) ones. Keep this as the single definition so those screens | ||
| * can't drift apart for the same site. | ||
| * <p> |
| // The rs detail needs a real site from the SiteStore; the legacy fragment can fall | ||
| // back to a dummy WP.com site built from the note, so it stays the catch-all. | ||
| if (site != null && note.getCommentId() != 0 && ActivityLauncher.shouldUseRsComments(this, site)) { | ||
| if (site != null && note.getCommentId() != 0 && SiteUtils.canUseWpRs(site)) { |
Member
There was a problem hiding this comment.
I tried for a while but was unable to generate a comment notification for testing this particular change. Were you able to test this flow?
Contributor
Author
There was a problem hiding this comment.
@dcalhoun Yes, I was able to test this successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RS comments screens now show automatically for any site with an application password, mirroring how RS Posts and Pages already work. Removes the
Feature.RS_UNIFIED_COMMENTStoggle and its two strings — the RS comments UI itself is unchanged.That left the posts, pages, and comments gates as three byte-identical copies of
site != null && site.hasApplicationPassword(), so they now use a singleSiteUtils.canUseWpRs(@Nullable SiteModel)call.Testing instructions
Comments on a site with an application password: