Skip to content

[THROWAWAY] Proof: #763 specs pass against the old lookup #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mokagio wants to merge 1 commit into from
Closed

[THROWAWAY] Proof: #763 specs pass against the old lookup #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,18 +262,9 @@ def matching_releases(repository:, &matcher)
client.releases(repository).select(&matcher).sort_by { |release| release[:id] }
end

# Returns the GitHub Release associated with a given tag, if any, including draft ones.
#
# @note Unlike a lookup by name, "the most recently created match" is not the right answer here: a git tag can
# only ever back a single *published* release, so if one of the matches is not a draft then it is the
# release owning that tag, and a more recent draft sharing the same `tag_name` is a leftover—typically
# from a re-run of the release finalization—rather than a successor. Only when no published release
# claims the tag yet do we fall back to the most recent draft, which is the case when uploading assets
# to a release that has not been published yet.
#
# THROWAWAY: reverted to the pre-#763 lookup, which returns whichever match the API happens to list first.
def find_release(repository:, version:)
matches = matching_releases(repository: repository) { |candidate| candidate.tag_name == version }
release = matches.reject { |candidate| candidate[:draft] }.last || matches.last
release = client.releases(repository).find { |candidate| candidate.tag_name == version }
return release unless release.nil?

release_for_tag(repository: repository, version: version)
Expand Down