refactor(swift): replace build scripts with xtask - #455
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 516a8da. Configure here.
|
/otto --modle=opus review this PR |
|
Kicked off a thorough review of PR #455 using Opus with a workspace to inspect the full diff and check behavior parity between the removed shell scripts and the new |
| - name: Set up Rust | ||
| uses: dtolnay/rust-toolchain@fa04a1451ff1842e2626ccb99004d0195b455a88 # master | ||
| with: | ||
| toolchain: 1.94.1 |
There was a problem hiding this comment.
Minor CI efficiency: unlike the sibling swift-build job, this swift-test matrix job doesn't add a Swatinem/rust-cache step, so cargo xtask swift test --skip-build recompiles xtask and all its deps from scratch on each of the 5 Xcode matrix entries (the uploaded artifact only contains WalletKit.xcframework + Sources, not target/). Adding a rust-cache step here would cut redundant compile time. Not blocking.
Review summary — ✅ Approve (one minor, non-blocking inline note)I checked out Behavior parity verified — the ports are faithful:
Other checks:
One behavior change worth calling out (intentional & documented, not a bug): the old Nice cleanup overall — good alignment with the existing Kotlin xtask pattern, solid error messages, and useful unit tests around the pure logic (path resolution, manifest rendering, simulator-ID parsing). |
|
Review complete on PR #455 (worldcoin/walletkit). Verdict: ✅ Approve (one minor, non-blocking note) The subagent checked out the branch, compared each new Posted to the PR:
No correctness bugs or parity gaps found. |

Summary
cargo xtask swiftcommandsTesting
cargo clippy -p xtask --all-targets -- -D warningscargo test -p xtaskNote
Medium Risk
Touches iOS XCFramework build and release packaging paths used in production Swift distribution, though behavior is largely a straight port from the removed scripts.
Overview
Moves Swift/iOS automation from deleted
swift/*.shscripts intocargo xtask swift(build,test,local,archive), aligned with the existing Kotlin xtask pattern.CI and release now invoke
cargo xtask swift build,cargo xtask swift test --skip-build, andcargo xtask swift archiveinstead of shell entrypoints; the Swift test matrix job also sets up Rust so xtask can run. Release workflow notes thatWALLETKIT_CARGO_FEATURESapplies to both Kotlin and Swift builds.Docs and helpers point at the new commands (root
README,swift/README.md, Nix docs);make_local_swift_package.shcallscargo xtask swift local. Local SPM output stays underswift/local_build/walletkit-swift.Reviewed by Cursor Bugbot for commit 147df78. Bugbot is set up for automated code reviews on this repo. Configure here.