Skip to content

Fix Windows and macOS CI hanging on Warcraft folder chooser #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 1 commit into from
Oct 14, 2026
Merged

Fix Windows and macOS CI hanging on Warcraft folder chooser #1461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/MapModelReuseTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
import de.peeeq.wurstscript.gui.WurstGui;
import de.peeeq.wurstscript.gui.WurstGuiCliImpl;
import de.peeeq.wurstscript.utils.CompilationCancellation;
import net.moonlightflower.wc3libs.port.Context;
import net.moonlightflower.wc3libs.port.mac.MacGameExeFinder;
import net.moonlightflower.wc3libs.port.win.WinGameExeFinder;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
import org.wurstscript.projectconfig.WurstProjectConfigData;
Expand All @@ -22,6 +25,25 @@
import static org.testng.Assert.*;

public class MapModelReuseTests {
@Test
public void runProbeDoesNotDiscoverAnInstalledGame() throws Exception {
Project project = project();
// A runner has no Warcraft installation. Discovery would open a modal folder chooser
// on Windows/macOS, so fail immediately if this compile-only fixture attempts it.
Context.pushService(WinGameExeFinder.class, new WinGameExeFinder() {
@Override public File find() { throw new AssertionError("RunProbe attempted Windows game discovery"); }
});
Context.pushService(MacGameExeFinder.class, new MacGameExeFinder() {
@Override public File find() { throw new AssertionError("RunProbe attempted macOS game discovery"); }
});
try {
compile(new RunProbe(project.root, List.of("-lua")), project, new WurstGuiCliImpl());
} finally {
Context.popService(MacGameExeFinder.class);
Context.popService(WinGameExeFinder.class);
}
}

@Test(dataProvider = "commands")
public void excludedVariableEventsDoNotPreserveSelectedGlobals(boolean build, boolean lua) throws Exception {
Project project = project();
Expand Down Expand Up @@ -373,7 +395,10 @@ private interface Probe {
private static class RunProbe extends RunMap implements Probe {
private WurstModel model;
RunProbe(File root, List<String> args) {
super(null, WFile.create(root), Optional.empty(), Optional.empty(), args, Optional.empty());
// Only compilation is exercised; an explicit fixture path bypasses installation
// discovery and its modal folder chooser on runners without Warcraft.
super(null, WFile.create(root), Optional.empty(), Optional.empty(), args,
Optional.of(new File(root, "Warcraft III.exe").getAbsolutePath()));
}
@Override public File compile(WurstGui gui, ModelManager manager, File script) throws Exception {
return compileScript(gui, manager, compileArgs, Optional.empty(), WurstProjectConfigData.empty(), false, script);
Expand Down
Loading