Skip to content

Uniform header inclusion#1343

Open
AntoinePrv wants to merge 1 commit intoxtensor-stack:masterfrom
AntoinePrv:headers
Open

Uniform header inclusion#1343
AntoinePrv wants to merge 1 commit intoxtensor-stack:masterfrom
AntoinePrv:headers

Conversation

@AntoinePrv
Copy link
Copy Markdown
Contributor

No description provided.

@serge-sans-paille
Copy link
Copy Markdown
Contributor

That's cool, but you also need tow rite some rule to ensure we don't regress on those, otherwise we're going to repeateadly have this.

I think I prefer having standard header include last, as a way to detect some missing includes hidden by transitive inclusion. This can be enforced by the following clang-format option:

IncludeBlocks: Regroup
IncludeCategories:
  - Regex:           '"\.\.?/.*"'
    Priority:        2
    SortPriority:    2
  - Regex:           '<.*'
    Priority:        3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants