[zigzagdev]

Motivation / 目的

While investigating a candidate for the console-command path-resolution cleanup, MakeManualSiteNamesJson was found to have its own divergent resolvePath()/toLocalDiskPath() implementations instead of using the shared ResolvesLocalDiskPaths trait. Investigating why revealed two real bugs, not just duplication.

コンソールコマンドのパス解決共通化のリファクタ候補を調査する中で、MakeManualSiteNamesJsonだけが独自resolvePath()/toLocalDiskPath()を持っていることが分かりました。単なる重複ではなく、実際に2つの不具合が
見つかりました。

What I have done / 実施内容

• Adopted ResolvesLocalDiskPaths for --in: resolvePath() used base_path() directly, which only happened to work because the documented default already includes the full storage/app/private/...prefix. Unlike every other command in this pipeline, it could not accept a disk-relative path (e.g. --in=unesco/manual_input.txt), silently resolving to the wrong location under the project root.
• Fixed a doubled private/ segment bug on --out: toLocalDiskPath() only stripped the storage/app/ prefix, not private/. With the documented default (storage/app/private/unesco/site_names_manual.json), the file actually landed at storage/app/private/private/unesco/site_names_manual.json (local disk root is storage/app/private), while the log line claimed the correct single-private path. Switched to ResolvesLocalDiskPaths::normalizeLocalDiskPath() and fixed the log line to print the real resolved path

Test Results / テスト結果

• php artisan test (full suite): 228 passed, no regressions
• MakeManualSiteNamesJsonTest: confirms --in accepts a disk-relative path, and --out no longer lands under a doubled private/ segment
• Verified end-to-end against real fixture files in the container before writing the tests

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.06%. Comparing base (8eba9d2) to head (420ef18).

Additional details and impacted files

@@                           Coverage Diff                           @@
##             refactor/console-commands-cleanup     #593      +/-   ##
=======================================================================
+ Coverage                                67.72%   69.06%   +1.33%     
+ Complexity                                1691     1687       -4     
=======================================================================
  Files                                      151      152       +1     
  Lines                                     8912     8915       +3     
=======================================================================
+ Hits                                      6036     6157     +121     
+ Misses                                    2876     2758     -118     

Files with missing lines	Coverage Δ
...c/app/Console/Commands/MakeManualSiteNamesJson.php	77.86% <100.00%> (+77.86%)	⬆️
...orldHeritage/Tests/MakeManualSiteNamesJsonTest.php	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zigzagdev]

Ok