Skip to content

Keep archived card dependency controls read-only - #2955

Merged
Chris0Jeky merged 7 commits into
mainfrom
issue-2936/archived-dependency-controls
Sep 11, 2026
Merged

Keep archived card dependency controls read-only#2955
Chris0Jeky merged 7 commits into
mainfrom
issue-2936/archived-dependency-controls

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Thinking could open an archived card read-only while its dependency widget still offered editing based on board permission alone. Those requests failed and obscured the current relationship display.

Require both the card's server-returned write permission and the graph permission for dependency controls and submission. Loading/failed card reads remain unavailable. The panel describes active connections and explains that archived relationships stay hidden until restore.

Closes #2936.

Validation:

  • Five regression failures reproduced before the fix; 13 focused component tests pass.
  • Full frontend: 6,477 passed, three existing skips.
  • Typecheck/build, scoped lint, docs/governance and diff checks pass.
  • Three real-API Chromium journeys pass, including Paper/Legacy archive and restore, retained relationships, explicit post-restore editing and viewer permissions.
  • Current-main integration at 7806f91: 31 combined component tests and production build pass.

No backend or dependency metadata changes. Actual assistive technology and non-Chromium browsers were not tested. Existing human release/private-hosting gates remain open.

Non-blocking follow-up #2958 covers refreshing card permission in place after an external restore/access grant. The current proof reopens the page to obtain the confirmed writable state.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T00:05:27.548870Z 3832139 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 10, 2026

Copy link
Copy Markdown
Owner Author

Independent adversarial review at 7806f91: SHIP, no findings. Reviewer inspected all five files and independently reran 13 component tests. Both controls and handlers require current card plus graph permission; loading removes the child until a confirmed read. Historical-filter wording matches the unchanged endpoint. Hosted exact-head CI remains pending.

Copy link
Copy Markdown
Owner Author

Completed worktree removed after tracked-tree, remote-head and ignored-file inventory checks. Logs, browser screenshots/results, review diff and cleanup inventory are retained at C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2936. Synthetic runtime database and generated outputs discarded; ports 4176/5376 are closed. Implementation claim stays review-only until merge.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7806f91c71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/components/thinking/CardDependencies.vue

Copy link
Copy Markdown
Owner Author

Current-base qualification: integrated main fad4935 (#2945) at head 9f97a29. The inbound 29-file Inbox delta is disjoint from this PR's owned changes. Independent scoped interaction review found no blocker: status polling remains read-only and does not alter proposal or board writes. Existing source review and local proof remain applicable. Fresh exact-head hosted CI is pending; this comment does not qualify a pending gate as passed.

Copy link
Copy Markdown
Owner Author

Current-base qualification at 8c7acb5: merged main7695211a0d31590c19845fd0e4cd559be521384e (#2949). Independent scoped review found no interaction blocker. The inbound 41-file type payload is byte-identical across the four Alpha candidates (SHA2566F80C8B1197DCDB73E63FF728DAF14A65645B1B2D2767DB410E95F57A7D95EBF), and this PR's owned paths are disjoint. Original source review stands; this was a read-only source/diff interaction pass, not new test execution. Fresh exact-head hosted CI remains required and pending.

Copy link
Copy Markdown
Owner Author

Current-base qualification at af9b070: merged main 93ca1cd. The added payload is exactly #2957's WorkspaceObservationReader.cs and WorkspaceObservationApiTests.cs changes. Independent scoped interaction review confirms the original PR diff is unchanged and found no direct interaction defect. Normalized binary diff SHA-256 matches main's landed payload: 4ABA3D6CE91FDC934ED93418723239C8FAF4C6B86DBA2200349C4BBCFCB6F2DE. No local tests were repeated for these disjoint paths. Fresh exact-head hosted CI remains pending; this is not yet merge qualification.

Copy link
Copy Markdown
Owner Author

Current-base qualification: head 3832139 merges main 02abedf. All five feature files are byte-identical to the previously reviewed head. Independent bounded interaction review returned SHIP: hierarchy invalidates stale dependency revisions, preserves hidden archived edges and leaves detached children active; server permissions remain authoritative. #2958 remains tracked.

npx vitest --run src/tests/components/CardDependencies.spec.ts src/tests/components/ThinkingDeckPanel.spec.ts src/tests/store/boardStore.hierarchyRefresh.spec.ts --maxWorkers=2: 37 passed in three files. No additional source edits. Current-head hosted CI remains required. Logs: taskdeck-alpha-evidence/2936/current-base-tests.log. Read-only review guard reported unchanged and cleaned successfully.

@Chris0Jeky
Chris0Jeky merged commit 34d1a4c into main Sep 11, 2026
36 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2936/archived-dependency-controls branch September 11, 2026 16:48
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Archive] Keep dependency controls read-only for archived cards

1 participant