Keep Review warnings tied to retained rows and truthful recovery - #2961
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Round-1 independent review: SHIP at f728187, no confirmed CRITICAL/HIGH. All 17 health-reactivity cases passed. A scratch-only differential probe reproduced a MEDIUM omitted recovery announcement when a successful list leg is followed by an awaited successful pin: preliminary recovery is retired, then final landing does not re-raise it. Final rows and health are correct. The probe passes with only this PR's runtime hunks reversed, confirming the regression boundary. Tracked on #2930, which now remains open; the PR body uses Refs. No MEDIUM fix cascade is added. Existing local full/focused/browser evidence stands, with synthetic browser responses and no actual screen-reader claim. Exact-head hosted CI remains pending. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f72818762f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hosted-check triage: cancelled Smart CI Plan check103059848180 explicitly reports a higher-priority waiting request for concurrency group smart-ci-control-2961. A newer metadata-triggered Smart CI run34533929669 is pending; run34533910175 was likewise superseded. This is evidenced workflow concurrency cancellation, not a claimed test flake. No rerun or workflow edit is needed while the replacement is pending. Required CI34533579911 has not passed yet; no merge qualification is claimed. |
|
Cleanup: source is pushed at f728187. After independent review, the clean worktree was removed with plain git worktree remove. Local evidence, full/targeted test logs, browser results and ignored inventory were exported to C:\Users\Public\codex-shell-home\taskdeck-alpha-evidence\2930-residual. The external differential-review probe remains alongside that evidence root. Disposable build/dependency outputs and synthetic database were removed; no owned browser/API listeners remain. This PR retains the Review composable/test lease until disposition. |
|
CI cancellation disposition: replacement Smart CI run 34533929669 completed successfully at f728187, including Plan and Required Gate. The older cancelled Plan was superseded by the documented metadata-event concurrency group. Required CI run 34533579911 is still running its API integration jobs; merge qualification remains pending. |
|
Current-base qualification at 59735f6: merged main 93ca1cd. The added payload is exactly #2957's WorkspaceObservationReader.cs and WorkspaceObservationApiTests.cs changes. Independent scoped interaction review confirms the original PR diff is unchanged and found no direct interaction defect. Normalized binary diff SHA-256 matches main's landed payload: 4ABA3D6CE91FDC934ED93418723239C8FAF4C6B86DBA2200349C4BBCFCB6F2DE. No local tests were repeated for these disjoint paths. Fresh exact-head hosted CI remains pending; this is not yet merge qualification. |
|
Current-base qualification at 85c0851, based on main 02abedf: all three feature files are byte-identical to the previously reviewed head. Bounded independent review SHIP; hierarchy/proposal and CardStore changes do not enter queue-read authority, retained health or recovery state. The delayed hash-pin announcement residual remains on #2930; this PR does not close that issue.
|
1 participant
Retained Review warnings could attach to a fresh hash-loaded row in the same board even though that row never belonged to the landed list. A successful list leg could also announce recovery while a failed pin kept a retained refusal visible. This change requires landed-list provenance for visible rows, preserves the intentionally empty same-scope warning, and retires recovery while a retained warning stands. The delayed successful-pin recovery announcement remains a tracked limitation below.
Three real-Vue regressions failed before repair. Focused Review checks pass 275 tests; full frontend passes 6,496 with three existing skips across 420 files. Two Chromium journeys pass with real authentication and synthetic proposal responses. Their clocks now pause before navigation, avoiding an extra startup poll found in the first run. Typecheck, production build, scoped lint and docs gates pass.
Integrated current main 7695211 without changing the residual patch; 313 combined Review/CardModal tests, typecheck and build pass at head f728187. Full suite/browser were not repeated for the disjoint type integration. No actual screen-reader speech or live-model claim. Independent review found no CRITICAL/HIGH; exact-head hosted CI is pending.
Only the Review composable, real-Vue health regression and existing browser fixture change. Canonical docs remain with their owners; a lane sync packet will carry delivery facts. This addresses the two warning cases from #2942 comment 5624225812. Review reproduced a MEDIUM successful delayed-pin recovery-announcement omission, so #2930 remains open for that exact residual; no claim that all recovery acceptance is complete. Earlier shipped acceptance is retained.
Refs #2930