Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 1 | Exercises by TTiamiyu · Pull Request #1295 · CodeYourFuture/Module-Data-Groups

TTiamiyu · 2026-07-26T12:04:45Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

…d values

…e test case for consistency

… empty array, single number, negative numbers, decimal numbers, and non-number values

… summation

cjyuan · 2026-07-31T15:31:18Z

+test("given an array with no duplicates, it returns a copy of the original array", () => {
+  expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]);
+});


Your function implementation is correct. However, this test could be improved to better ensure
that any future changes continue to align with the expected behavior described on line 29:

Then it should return a copy of the original array

This test should fail if the function returns the original array (instead of a copy of the original array).

The current test checks only if both the original array and the returned array contain identical elements.
In order to validate the returned array is a different array, we need an additional check.

Can you find out what this additional check is?

i found that using a .toBe and .not.toBe assertions would work better than .toEqual assertion for this test, i have changed the assertions and also added extra assertions to cater for future changes

toEqual() and toBe() serve differerent purposes. In this test you need both.

that is very true, most of the test cases in the .test.js file have both assertions to check the correctness of the values and also protect against just returning the list as is.

cjyuan · 2026-07-31T15:36:13Z

+test("given an array with only non-number values, return the least surprising value", () => {
+  expect(findMax(["a", "c", "e"])).toBe(-Infinity);
+});


When a string representing a valid numeric literal (for example, "300") is compared to a number,
JavaScript first converts the string into its numeric equivalent before performing the comparison.
As a result, the expression 20 < "300" evaluates to true.

To test if the function can correctly ignore non-numeric values, you may want to include a string such as "300" in the relevant test cases.

thank you for pointing that out, i did not think of that and i have adjusted the test case to include a string with numbers.

cjyuan · 2026-07-31T15:37:14Z

@@ -1,4 +1,6 @@
 function sum(elements) {
+  const numbers = elements.filter((item) => typeof item === "number");


What do you expect from the following function calls (on extreme cases)?
Does your function return the value you expected?

sum([NaN, 1]); sum([Infinity, -Infinity]);

No, it wouldn’t return what is expect, i have Incorporated these extreme cases in the test and also improved the sum.js code to cater for such extremes.

…ure changes.

TTiamiyu added 9 commits July 26, 2026 09:27

Refactor calculateMedian function to handle non-array inputs and mixe…

f7ce2f5

…d values

Implement dedupe function and add tests for empty and unique arrays

25d86f0

Add test for empty array case in max function

5201774

Add tests for various scenarios in max function

4e5a380

Fix findMax function to correctly filter non-numeric values and updat…

1c07c61

…e test case for consistency

Implement tests for sum function to cover various scenarios including…

c52700a

… empty array, single number, negative numbers, decimal numbers, and non-number values

Fix sum function test to return 0 for empty array case

0667c52

Refactor sum function to filter non-numeric values and ensure correct…

7d6ad3c

… summation

Refactor includes function to use for...of loop for improved readability

2abe1ec