-
-
Notifications
You must be signed in to change notification settings - Fork 323
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 1 | Exercises #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TTiamiyu
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
TTiamiyu:data-groups-sprint1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f7ce2f5
Refactor calculateMedian function to handle non-array inputs and mixe…
TTiamiyu 25d86f0
Implement dedupe function and add tests for empty and unique arrays
TTiamiyu 5201774
Add test for empty array case in max function
TTiamiyu 4e5a380
Add tests for various scenarios in max function
TTiamiyu 1c07c61
Fix findMax function to correctly filter non-numeric values and updat…
TTiamiyu c52700a
Implement tests for sum function to cover various scenarios including…
TTiamiyu 0667c52
Fix sum function test to return 0 for empty array case
TTiamiyu 7d6ad3c
Refactor sum function to filter non-numeric values and ensure correct…
TTiamiyu 2abe1ec
Refactor includes function to use for...of loop for improved readability
TTiamiyu 21c4d2a
Refactor dedupe tests to improve clarity and structure in case of fut…
TTiamiyu 4b9ea66
Update max function test to include string representation of numbers
TTiamiyu 87afb14
Enhance sum function to filter out NaN values for accurate summation
TTiamiyu b70a0a4
Add tests for NaN handling and Infinity cases in sum function
TTiamiyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| function dedupe() {} | ||
| function dedupe(list) { | ||
| return list.filter((item, index) => index === list.indexOf(item)); | ||
| } | ||
|
|
||
| module.exports = dedupe; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| function findMax(elements) { | ||
| const numbers = elements.filter((item) => typeof item === "number"); | ||
| return Math.max(...numbers); | ||
| } | ||
|
|
||
| module.exports = findMax; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| function sum(elements) { | ||
| const numbers = elements.filter( | ||
| (item) => typeof item === "number" && !Number.isNaN(item) | ||
| ); | ||
| return numbers.reduce((total, current) => total + current, 0); | ||
| } | ||
|
|
||
| module.exports = sum; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.