Skip to content

Adding allrealms topology and vlock authentication methods for pam_responder tests - #262

Merged
danlavu merged 3 commits into
SSSD:masterfrom
danlavu:topology-all-dc
Aug 20, 2026
Merged

Adding allrealms topology and vlock authentication methods for pam_responder tests#262
danlavu merged 3 commits into
SSSD:masterfrom
danlavu:topology-all-dc

Conversation

@danlavu

@danlavu danlavu commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
  • A workaround for tests that require multiple domains.
  • feat(su): add vlock_smartcard() to SUAuthenticationUtils

Co-authored-by: Cursor cursoragent@cursor.com

@danlavu danlavu changed the title Adding ALLREALMS topology. adding allrealms topology. Jul 31, 2026
@pbrezina

pbrezina commented Aug 12, 2026

Copy link
Copy Markdown
Member

I think you also need to add a topology controller to handle the setup? Or is client topology controller really sufficient? What is the use case?

@danlavu

danlavu commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

I think you also need to add a topology controller to handle the setup? Or is client topology controller really sufficient? What is the use case?

It's sufficient; the original test used dummy Kerberos realms; the realms just need to be resolvable.

@danlavu danlavu changed the title adding allrealms topology. Adding allrealms topology and vlock authentication methods for pam_responder tests Aug 13, 2026
Dan Lavu and others added 2 commits August 14, 2026 00:40
A workaround for tests that require multiple domains.
Add vlock_smartcard_with_output() and vlock_smartcard() methods to
SUAuthenticationUtils to encapsulate the expect script that logs in
via su -l, locks the terminal with vlock, verifies a wrong PIN is
rejected, then unlocks with the correct smartcard PIN.

Co-authored-by: Cursor <cursoragent@cursor.com>
@pbrezina

Copy link
Copy Markdown
Member

I think you also need to add a topology controller to handle the setup? Or is client topology controller really sufficient? What is the use case?

It's sufficient; the original test used dummy Kerberos realms; the realms just need to be resolvable.

Maybe add a comment there to say that if working Kerberos realm is required, we need to change it?

@danlavu

danlavu commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Maybe add a comment there to say that if working Kerberos realm is required, we need to change it?

I'm using the term 'dummy' loosely, the realm is working, the test does create users in all raelms and ensures that tickets can be issued. I think it's fine then, is that fine with you?

@danlavu
danlavu requested a review from krishnavema August 19, 2026 12:57

@krishnavema krishnavema left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danlavu
danlavu merged commit 24bcc91 into SSSD:master Aug 20, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants