Filter walrus version from trampoline snapshots - #187
Merged
Conversation
Assisted-By: devx/db2a5897-58c0-416b-802a-3a871e0b1dcc
Assisted-By: devx/db2a5897-58c0-416b-802a-3a871e0b1dcc
adampetro
marked this pull request as ready for review
July 22, 2026 18:00
jeffcharles
reviewed
Jul 22, 2026
jeffcharles
left a comment
jeffcharles
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just have the one question about the fuel change.
| let (_, logs, fuel) = run_example("log-past-capacity", vec![])?; | ||
| assert_eq!(logs, format!("{}{}", "a".repeat(991), "b".repeat(10))); | ||
| assert_fuel_consumed_within_threshold(928, fuel); | ||
| assert_fuel_consumed_within_threshold(965, fuel); |
Contributor
There was a problem hiding this comment.
Any idea why the fuel consumed changed?
Contributor
Author
There was a problem hiding this comment.
I believe it is a change in the latest Rust version, see #186 which has the same test failure, which I would also expect on main
jeffcharles
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[WALRUS-VERSION]log-past-capacityfuel expectation for the current Rust compilerTesting
cargo testcargo test -p shopify_function_trampoline disassemble_trampoline