Skip to content

Filter walrus version from trampoline snapshots #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adampetro merged 2 commits into from
Jul 23, 2026
Merged

Filter walrus version from trampoline snapshots #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed219aa
Filter walrus version from trampoline snapshots
adampetro Jul 22, 2026
f91da4b
Update expected logging fuel consumption
adampetro Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration_tests/tests/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ fn test_log_past_capacity() -> Result<()> {
.map_err(|e| anyhow::anyhow!("Failed to prepare example: {e}"))?;
let (_, logs, fuel) = run_example("log-past-capacity", vec![])?;
assert_eq!(logs, format!("{}{}", "a".repeat(991), "b".repeat(10)));
assert_fuel_consumed_within_threshold(928, fuel);
assert_fuel_consumed_within_threshold(965, fuel);

@jeffcharles jeffcharles Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the fuel consumed changed?

@adampetro adampetro Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is a change in the latest Rust version, see #186 which has the same test failure, which I would also expect on main

Ok(())
}

Expand Down
2 changes: 1 addition & 1 deletion trampoline/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ assert_cmd = "2.2.0"
predicates = "3.1.4"
wat = "1.245.1"
wasmprinter = "0.246.2"
insta = { version = "1.47", features = ["glob"] }
insta = { version = "1.47", features = ["filters", "glob"] }
15 changes: 11 additions & 4 deletions trampoline/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,10 +684,17 @@ mod test {
//
// to update the snapshots, either run `cargo insta review` or use the `INSTA_UPDATE`
// environment variable as documented at https://docs.rs/insta/latest/insta/index.html#updating-snapshots
insta::glob!("test_data/*.wat", |path| {
let input = wat::parse_file(path).unwrap();
let actual = trampoline_wat(&input).unwrap();
insta::assert_snapshot!(actual);
insta::with_settings!({
filters => vec![(
r#"\(processed-by "walrus" "[^"]+"\)"#,
r#"(processed-by "walrus" "[WALRUS-VERSION]")"#,
)],
}, {
insta::glob!("test_data/*.wat", |path| {
let input = wat::parse_file(path).unwrap();
let actual = trampoline_wat(&input).unwrap();
insta::assert_snapshot!(actual);
});
});
}

Expand Down
2 changes: 1 addition & 1 deletion ...src/snapshots/shopify_function_trampoline__test__disassemble_trampoline@consumer.wat.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,6 @@ input_file: trampoline/src/test_data/consumer.wat
call 16
)
(@producers
(processed-by "walrus" "0.26.0")
(processed-by "walrus" "[WALRUS-VERSION]")
)
)
2 changes: 1 addition & 1 deletion ...ne/src/snapshots/shopify_function_trampoline__test__disassemble_trampoline@empty.wat.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ input_file: trampoline/src/test_data/empty.wat
---
(module
(@producers
(processed-by "walrus" "0.26.0")
(processed-by "walrus" "[WALRUS-VERSION]")
)
)
Loading