unify(ww3d2): Merge WW3D and move it to Core

[bobtista]

• Relates to Merge Generals and Zero Hour code into one #555
• Helps clean up chore(ww3d2): add IRenderBackend Interface #2613

Generals and Zero Hour differ only by comments and the disabled WWShade SHD_FLUSH hook.

Now Generals uses the Zero Hour implementation, and ww3d.cpp and ww3d.h are moved to Core using unify_move_files.py

Todo:

• Confirm both implementations are identical before moving
• Configure both game targets
• Replicate to Generals

[greptile-apps]

Greptile Summary

Moves the shared WW3D implementation into Core.

• Enables ww3d.cpp and ww3d.h in the Core WW3D2 interface target.
• Removes the per-game implementations and configures both game targets to consume the Core sources.
• Updates affected headers to include the shared WW3D2/ww3d.h path.
• Records the completed move in the unification script.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt	Adds the moved WW3D implementation and header to the shared interface source list consumed by both game libraries.
Core/Libraries/Source/WWVegas/WW3D2/ww3d.cpp	Relocates the existing Zero Hour WW3D implementation into Core without content changes.
Core/Libraries/Source/WWVegas/WW3D2/ww3d.h	Relocates the existing WW3D public interface into Core without content changes.
Generals/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt	Stops compiling the deleted Generals-local implementation so the target consumes the shared Core source.
GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/CMakeLists.txt	Stops compiling the moved Zero Hour implementation locally so the target consumes the shared Core source.
scripts/cpp/unify_move_files.py	Documents the completed WW3D file unification through commented maintenance-script entries.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Core["corei_ww3d2<br/>shared ww3d.cpp / ww3d.h"]
  Generals["g_ww3d2<br/>RTS_GENERALS"]
  ZeroHour["z_ww3d2<br/>RTS_ZEROHOUR"]
  Core --> Generals
  Core --> ZeroHour

Loading

_{Reviews (5): Last reviewed commit: "unify(ww3d2): Move WW3D to Core" | Re-trigger Greptile}

[xezon]

Is this still needed?

[bobtista]

I think so. mapper.h and rinfo.h in both game trees still include ww3d.h bare. Those two headers are pulled in from outside the ww3d2 targets, and those get the WWVegas roots but not the WW3D2 subdirs. They're now WW3D2/ww3d.h, matching #3032's rule of qualifying header edges that cross the Core/product partition.

[xezon]

Right, the headers must have fully qualified paths because they can be included by other libs.

[xezon]

pull id is missing in commit titles.

Can say ww3d instead of WW3D because of the file name. WW3D is class name.