chore: retire src/eval.ts and npm run eval#24
Merged
Conversation
`src/eval.ts` and the `npm run eval` script have been dead-code-walking since Stack E shipped `npm run sim` (improvements.md #16, resolved 2026-04-30). The two runners coexisting under similar names actively misled engineers and customer forks. This change deletes the legacy runner and scrubs all doc references. The Vapi `/eval` REST endpoint, the `evals` resource type, the `/eval/simulation/*` simulation API, and `docs/learnings/simulations.md` are all unaffected — only the local CLI runner is gone. If customer-fork automation still invokes `npm run eval`, swap to `npm run sim -- <org> --suite <name> --target <name>`.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/eval.tsand thenpm run evalscript. Both have been dead-code-walking since Stack E shippednpm run sim(improvements.md entry feat: push --dry-run preview mode #16, resolved 2026-04-30). The two runners coexisting under similar names actively misled engineers and customer forks.README.md(commands table row, Direct-Mode example block, the### Running Evalssection, thesrc/directory-tree comment) andAGENTS.md(testing-commands block).src/sim.tsandsrc/sim-cmd.tsso they no longer cite the deleted file. Technical nuance ("env-loading is inlined to avoid triggeringconfig.tsCLI arg parsing when imported from tests") is preserved.The Vapi
/evalREST endpoint, theevalsresource type, the/eval/simulation/*simulation API, anddocs/learnings/simulations.mdare all unaffected — only the local CLI runner is gone.Customer-fork callers: if any of your automation still invokes
npm run eval, swap tonpm run sim -- <org> --suite <name> --target <name>. SeeAGENTS.mdfor syntax.Out of scope (pre-existing, not introduced here):
README.mdaround lines 520-530. Fix separately.src/eval.tsinsideimprovements.mdandrequested improvements.md. Those are user-curated trackers and per repo convention are not modified in feature/chore PRs.biome.json/prettierconfig — running biome defaults reformats files spaces→tabs. Caught in this PR and reverted; worth a separate hygiene PR to pick a convention and lock it in.Skipped pipeline stages:
test-writerskipped — pure deletion of unreachable code with no new behavior to specify. The existingtests/sim.test.tsalready covers the surviving runner.code-reviewerran and approved with zero blocking findings.Test plan
improvements.md/requested improvements.md, intentionally untouched)