Repository navigation
Add interlock-cb to third-party libraries - #13336
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13336 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 135 135
Lines 49992 49992
Branches 2597 2597
=======================================
Hits 49507 49507
Misses 366 366
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Have you tried reading the contrib doc tho? |
|
FTR, there's now an ongoing incident w/ GHA, which is why some runners crash: https://www.githubstatus.com/incidents/qcvjkzcs7j74. The maintainers will need to restart the jobs once that outage is over. |
|
@webknjaz Thanks for the pointer! I followed the contributor setup instructions and ran make doc successfully. I’ve updated the PR description accordingly. |
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The changes are documentation-only, use configured reStructuredText roles, and conform to the surrounding third-party entry and news-fragment patterns. Reviews (1): Last reviewed commit: "Merge branch 'master' into docs/add-inte..." | Re-trigger Greptile |
Merging this PR will degrade performance by 17.51%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| 👁 | test_list_element_pattern_redos_payload[whitespace_run_after_content] |
29.7 ms | 36.1 ms | -17.51% |
Comparing bagowix:docs/add-interlock (6eac742) with master (2930321)
Footnotes
-
83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Backport to 3.15: 💚 backport PR created✅ Backport PR branch: Backported as #13531 🤖 @patchback |
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #13532 🤖 @patchback |
What do these changes do?
Adds interlock-cb to the third-party libraries page. I am the author of interlock-cb.
Are there changes in behavior for the user?
No aiohttp behavior changes. The documentation now points users to an aiohttp client circuit
breaker middleware that maintains one breaker per host and trips on failure rate or slow
responses.
Is it a substantial burden for the maintainers to support this?
No. This is a documentation-only entry for an independently maintained third-party library.
Related issue number
N/A.
Checklist
CONTRIBUTORS.txt(N/A: no code modification)CHANGES/folderAgent run output
git diff --check: passed.venv/bin/pre-commit run --files docs/third_party.rst: passedmake doc: passedDrafted with Codex (GPT-5); reviewed by @bagowix.