fix(server): resolve non-Linux clippy errors in shard binding - #4144
Merged
Conversation
CPU and memory binding are no-ops on non-Linux platforms but retain the fallible Linux API. Allow unused_self and unnecessary_wraps only on non-Linux targets to preserve consistent method signatures. Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4144 +/- ##
=============================================
- Coverage 86.64% 61.00% -25.64%
Complexity 1455 1455
=============================================
Files 1267 1266 -1
Lines 211572 172178 -39394
Branches 176797 137378 -39419
=============================================
- Hits 183310 105037 -78273
- Misses 23778 62754 +38976
+ Partials 4484 4387 -97
🚀 New features to boost your workflow:
|
hubcio
approved these changes
Sep 12, 2026
spetz
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #
Relates to #
Rationale
On non-Linux platforms,
ShardInfo::bind_cpuandbind_memoryare no-ops, triggering Clippy'sunused_selfandunnecessary_wrapslints.What changed?
Add narrowly scoped, non-Linux-only lint allowances to preserve the shared API and Linux error handling without changing runtime behavior.
Validation on macOS:
--all-features --all-targets -- -D warnings.Local Execution
Passed
Ran
AI Usage