Skip to content

fix(server): resolve non-Linux clippy errors in shard binding #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hubcio merged 2 commits into from
Sep 12, 2026
Merged

fix(server): resolve non-Linux clippy errors in shard binding #4144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ad1a8
fix(server): resolve non-Linux clippy errors in shard binding
Standing-Man Sep 11, 2026
2325654
Merge branch 'master' into clippy-check
hubcio Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions core/server/src/shard_allocator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,14 @@ pub struct ShardInfo {
impl ShardInfo {
/// Pin the calling thread to this shard's cores. On non-Linux this
/// does nothing (no-op). Empty core set also does nothing.
#[cfg_attr(
not(target_os = "linux"),
allow(
clippy::unused_self,
clippy::unnecessary_wraps,
reason = "Keep the same API as the fallible Linux binding implementation"
)
)]
pub fn bind_cpu(&self) -> Result<(), ShardingError> {
#[cfg(target_os = "linux")]
{
Expand Down Expand Up @@ -241,6 +249,14 @@ impl ShardInfo {
/// Pin the calling thread's memory to this shard's NUMA node so
/// allocations stay local and fast. Does nothing if no node is set.
/// On non-Linux this does nothing (no-op), mirroring [`Self::bind_cpu`].
#[cfg_attr(
not(target_os = "linux"),
allow(
clippy::unused_self,
clippy::unnecessary_wraps,
reason = "Keep the same API as the fallible Linux binding implementation"
)
)]
pub fn bind_memory(&self) -> Result<(), ShardingError> {
#[cfg(target_os = "linux")]
{
Expand Down
Loading