[SPARK-58343][SQL][TESTS] Add unit test for TypeUtils.typeWithProperEquals#57518
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58343][SQL][TESTS] Add unit test for TypeUtils.typeWithProperEquals#57518uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
Jul 25, 2026
Member
Author
|
Thank you @dongjoon-hyun! Merging to master/4.x |
uros-b
added a commit
that referenced
this pull request
Jul 26, 2026
…uals ### What changes were proposed in this pull request? Adds a focused unit test for `TypeUtils.typeWithProperEquals` in `TypeUtilsSuite`. The predicate was previously only referenced in a code comment, never directly asserted. The test covers atomic types (true), UTF8_BINARY string (true), a collated string (false), binary type (false), and complex types (false). ### Why are the changes needed? `typeWithProperEquals` gates several expressions (higher-order functions, complex-type extractors, collection ops, PivotFirst) but had no direct coverage. The added assertions pin its contract, including the special-cased BinaryType and collation branches. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR is the test. `build/sbt "catalyst/testOnly *TypeUtilsSuite"`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57518 from uros-b/test-typeutils-properequals. Lead-authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Co-authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit ced139f) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds a focused unit test for
TypeUtils.typeWithProperEqualsinTypeUtilsSuite. The predicate was previously only referenced in a code comment, never directly asserted. The test covers atomic types (true), UTF8_BINARY string (true), a collated string (false), binary type (false), and complex types (false).Why are the changes needed?
typeWithProperEqualsgates several expressions (higher-order functions, complex-type extractors, collection ops, PivotFirst) but had no direct coverage. The added assertions pin its contract, including the special-cased BinaryType and collation branches.Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR is the test.
build/sbt "catalyst/testOnly *TypeUtilsSuite".Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)