Skip to content

[SPARK-58343][SQL][TESTS] Add unit test for TypeUtils.typeWithProperEquals #57518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uros-b wants to merge 1 commit into from
Closed

[SPARK-58343][SQL][TESTS] Add unit test for TypeUtils.typeWithProperEquals #57518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TypeUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,24 @@ class TypeUtilsSuite extends SparkFunSuite with SQLHelper {
ArrayType(StringType, containsNull = false) :: Nil)
}

test("typeWithProperEquals") {
// Atomic types have proper equals.
assert(TypeUtils.typeWithProperEquals(IntegerType))
assert(TypeUtils.typeWithProperEquals(DoubleType))
assert(TypeUtils.typeWithProperEquals(BooleanType))
assert(TypeUtils.typeWithProperEquals(TimestampType))
// UTF8_BINARY strings support binary equality.
assert(TypeUtils.typeWithProperEquals(StringType))
// Non-UTF8_BINARY (collated) strings do not support binary equality.
assert(!TypeUtils.typeWithProperEquals(StringType("UTF8_LCASE")))
// Binary type does not have proper equals.
assert(!TypeUtils.typeWithProperEquals(BinaryType))
// Complex types are not covered.
assert(!TypeUtils.typeWithProperEquals(ArrayType(IntegerType)))
assert(!TypeUtils.typeWithProperEquals(MapType(StringType, IntegerType)))
assert(!TypeUtils.typeWithProperEquals(new StructType().add("a", IntegerType)))
}

test("TIMESTAMP_NANOS_TYPES_ENABLED defaults to Utils.isTesting") {
assert(SQLConf.get.timestampNanosTypesEnabled === Utils.isTesting)
}
Expand Down