Skip to content

fix(deps): backport reth eth_getLogs blocking-pool fix (#26999 + follow-ups) - #6416

Merged
niran merged 2 commits into
releases/v1.5.2from
bb/v1.5.2-reth-getlogs-blocking-io
Nov 4, 2026
Merged

niran merged 2 commits into
releases/v1.5.2from
bb/v1.5.2-reth-getlogs-blocking-io

Conversation

@BrianBland

@BrianBland BrianBland commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #6230.

Summary

Backports the upstream reth eth_getLogs blocking-pool fix to the releases/v1.5.2 line by moving the reth pin to base/reth#38, which cherry-picks:

main already has these through reth 2.7. Only Cargo.toml, Cargo.lock and etc/upstream-pins/reth.toml change: the reth source moves from tag = "base-v2.5.2.8" to tag = "base-v2.5.2.10" (e8ec60bd2fb001b93222daa47bc384d44932ef39, the base/reth#38 merge). The tag also carries base/reth#27 from base-v2.5.2.9 (full-preset RocksDB index downloads).

Testing

type=routine
risk=low
impact=sev5

…1.5.2

Co-authored-by: Toshi <toshi-noreply@coinbase.com>
@depot-code-access

depot-code-access Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

✅ All benchmarks green — 14 within ±2% (deterministic instruction counts). View run

Benchmark details (14)
Benchmark Base (target) Head (this PR) Δ instructions
batch_queue/drain/drain_cached_span_batches 242,027 242,027 +0.0%
batch_transaction/encode_in_place/encode_in_place 4,199,759 4,199,759 +0.0%
batch_transaction/temporary_frame_buffers/temporary_frame_buffers 8,408,350 8,408,350 +0.0%
flashblock_decode/decode/brotli 3,296,484 3,296,484 +0.0%
flashblock_decode/decode/plain_json 2,280,194 2,280,194 +0.0%
flz/compress_len/real_contract_call 43,148 43,148 +0.0%
flz/compress_len/synthetic_0 38,205 38,205 +0.0%
flz/compress_len/synthetic_1 54,682 54,682 +0.0%
flz/compress_len/synthetic_2 147,976 147,976 +0.0%
flz/data_gas 43,059 43,059 +0.0%
flz/tx_estimated_size 43,056 43,056 +0.0%
frame_parse/decode/single_4kib 1,031 1,031 +0.0%
frame_parse/parse_frames/few_large 1,053,062 1,053,062 +0.0%
frame_parse/parse_frames/many_small 154,763 154,763 +0.0%

@depot-code-access

depot-code-access Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Acceptance Tests: ✅ Passed

3/3 checks passed · Checks & reports

Acceptance report
  • smoke / chain-identity — passed: chain identity matched
    • Expected: 84538453
    • Observed: 84538453
  • smoke / production — passed: head advanced
    • Expected: {"minimum_blocks":3}
    • Observed: {"delta":3,"from":5,"last":8,"required_delta":3}
  • smoke / validator-converges — passed: heads converged on a common canonical block
    • Expected: {"common_height_hash":true,"max_lag_blocks":5}
    • Observed: {"common_height":8,"hash":"0x6669406ad5557690102e2f57a7387f4ff75c2795221ca38c7ad946de7e0877f5","high":8,"lag":0,"low":8,"low_timestamp":1793805326,"maximum_lag":5,"minimum_timestamp":0}

@depot-code-access

depot-code-access Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Base Std historical fork tests

Fork Result Passed Failed Skipped base/base base-anvil base-std
Beryl pass 616 0 13 07610b33 98e7839c 520d069b
Cobalt pass 725 0 14 07610b33 98e7839c bbfb352e
Denim pass 757 0 14 07610b33 98e7839c 7321d891

View run

@BrianBland BrianBland changed the title fix(deps): pin reth eth_getLogs blocking-pool fixes on v1.5.2 fix(deps): backport reth eth_getLogs blocking-pool fix (#26999 + follow-ups) Nov 3, 2026
@wlawt
wlawt marked this pull request as ready for review November 4, 2026 15:18
@niran
niran merged commit 71dcd25 into releases/v1.5.2 Nov 4, 2026
36 checks passed
@niran
niran deleted the bb/v1.5.2-reth-getlogs-blocking-io branch November 4, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants