Repository navigation
fix(rpc): backport eth_getLogs blocking-pool fixes to v2.5.2 - #38
Merged
Merged
Conversation
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> (cherry picked from commit de401d9)
…digmxyz#26999) (cherry picked from commit 1f94488)
(cherry picked from commit 055fafc) Conflict resolution for v2.5.2: kept the range-mode header buffer at Vec::with_capacity(self.max_range). The remaining-header bound comes from upstream PR 26971, which is not part of this backport. Co-authored-by: Toshi <toshi-noreply@coinbase.com>
wlawt
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Backports the upstream
eth_getLogsblocking-pool fix ontobackport/v2.5.2/mainfor the Basereleases/v1.5.2line. Upstream ships it in reth 2.7.What
Cherry-picked in order with
-xprovenance:paradigmxyz#26776 and paradigmxyz#26999 apply cleanly. paradigmxyz#27000 had one conflict: the range-mode header buffer keeps
Vec::with_capacity(self.max_range), because the tighter bound comes from upstream paradigmxyz#26971, which isn't backported. No other changes.Testing
cargo test -p reth-rpc --lib eth::filter: 12 passed.cargo clippy -p reth-rpc -p reth-rpc-eth-api --lib --tests -- -D warnings: clean.Notes
Not tagged yet; after merge the next tag in the series is
base-v2.5.2.10.