CFE-4682: Fix memory leak in EvalContextHeapPersistentSave#6166
Closed
nickanderson wants to merge 1 commit into
Closed
CFE-4682: Fix memory leak in EvalContextHeapPersistentSave#6166nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
nickanderson
force-pushed
the
CFE-4682/persistent-class-skip-fix
branch
from
e1dde05 to
7243ba2
Compare
nickanderson
commented
Jun 5, 2026
| { | ||
| Log(LOG_LEVEL_DEBUG, | ||
| "Class '%s' is already set but not persistent" | ||
| " — allowing evaluation to persist it", |
Member
Author
There was a problem hiding this comment.
to /potentially/ persist it.
nickanderson
force-pushed
the
CFE-4682/persistent-class-skip-fix
branch
from
7243ba2 to
f239d8d
Compare
5 tasks
existing_info was allocated via xcalloc but never freed on the early-return (preserve) path, the early-return (read error) path, or the normal fall-through path.
nickanderson
force-pushed
the
CFE-4682/persistent-class-skip-fix
branch
from
f239d8d to
f227eb1
Compare
nickanderson
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
existing_infoinEvalContextHeapPersistentSave()(eval_context.c)existing_infowas allocated viaxcallocbut never freed on three paths:ReadDBerror early-returnTest plan
test_persistent_class_timer_policyexercises the PRESERVE early-return path that leaksxcallocallocations now have matchingfreeon every return pathTicket: CFE-4682
🤖 Generated with Claude Code