Skip to content

fix(deps): patch qs to 6.16.1 - #1434

Open
cipherstash-agent wants to merge 1 commit into
mainfrom
fix/cip-5247-qs
Open

cipherstash-agent wants to merge 1 commit into
mainfrom
fix/cip-5247-qs

Conversation

@cipherstash-agent

Copy link
Copy Markdown
Contributor

Summary

Patches the transitive qs dependency to 6.16.1.

Advisories

Changes

Lockfile Before After
pnpm-lock.yaml qs 6.16.0 qs 6.16.1

qs is reached through body-parser → express → @modelcontextprotocol/sdk → @anthropic-ai/claude-agent-sdk → @cipherstash/wizard. The change came from pnpm update -r qs, so it needed no override and touches only the lockfile.

Verification

  • pnpm install --frozen-lockfile --ignore-scripts passes on the branch.
  • The dependency scan finds no lockfile that resolves a vulnerable qs (only 6.16.1 is resolved).
  • The diff is pnpm-lock.yaml only.
  • No unfixed advisories remain.

CI runs the test suites.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7r7LjBn2Pj9k3RHUWF
@cipherstash-agent
cipherstash-agent requested a review from a team as a code owner October 28, 2026 19:03
@changeset-bot

changeset-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1f546ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f4116c1a-5b09-4192-9f20-956448245f6b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cipherstash-agent cipherstash-agent left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review attestation — source: /code-review medium followed by company-skills:cross-check-review-findings, run against head 1f546ba.

Result: no critical or blocking issues. No new findings.

  • The diff is pnpm-lock.yaml only: qs 6.16.0 → 6.16.1, which is the fixed version for GHSA-6pq8-jhm2-2vcw.
  • The package entry, body-parser and express references were updated together, and the integrity hash matches the registry value for qs@6.16.1.
  • 6.16.1 was published 2026-10-14, so it is past the 7-day minimumReleaseAge.
  • Three observations were dropped as non-defects or already covered:
    • no overrides entry pins qs (the PR deliberately skips one);
    • qs 6.16.2 is newer but still inside the release-age window;
    • the missing changeset is already flagged by changeset-bot.

Nothing to fix before merge.


Generated by Claude Code

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. The change is to pnpm-lock.yaml only: qs 6.16.0 → 6.16.1 (reached through body-parser / express).

Verified:

  • GHSA-6pq8-jhm2-2vcw (CVE-2026-110816) affects >= 6.7.0, <= 6.16.0, and 6.16.1 is the first fixed version.
  • The lockfile integrity hash is the same as the one npm publishes for qs@6.16.1.
  • 6.16.1 was published on 2026-10-14, so it is past the 7-day minimumReleaseAge. A later re-resolve cannot fall back to 6.16.0.
  • pnpm-lock.yaml is the only tracked lockfile that resolves qs, and it resolves no other version.
  • No changeset is necessary, because no published manifest changes.

Nit (not blocking): no override stops a later re-resolve from going back to a vulnerable qs. This is acceptable because the patched version is past the cooldown.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants