Skip to content

RCBC-535: Upgrade to Minitest 6#228

Merged
DemetrisChr merged 1 commit into
couchbase:mainfrom
DemetrisChr:RCBC-535-minitest-6
May 28, 2026
Merged

RCBC-535: Upgrade to Minitest 6#228
DemetrisChr merged 1 commit into
couchbase:mainfrom
DemetrisChr:RCBC-535-minitest-6

Conversation

@DemetrisChr

Copy link
Copy Markdown
Contributor

The only change we need is adding minitest-mock as a dependency (no longer bundled with minitest), which is needed for the active support test cases.

@DemetrisChr DemetrisChr requested review from avsej and Copilot and removed request for avsej May 28, 2026 13:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the development dependency on Minitest to the 6.x series and adds the newly-separate minitest-mock gem (Minitest 6 no longer bundles mock/stub support), which is required by the Active Support–derived test cases that rely on Time.stub and ActiveSupport::Testing::MethodCallAssertions. The PR also re-enables three previously skipped scan concurrency tests.

Changes:

  • Pin minitest to ~> 6.0 (previously < 6.0) in the :development group of the Gemfile.
  • Add minitest-mock as an explicit development dependency.
  • Remove skip("Skipped until CXXCBC-345 is resolved") from the three scan concurrency tests in test/scan_test.rb.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Gemfile Bumps minitest to ~> 6.0 and adds the standalone minitest-mock gem needed for Time.stub and friends.
test/scan_test.rb Removes CXXCBC-345 skip guards from the range/prefix/sampling scan concurrency tests, re-enabling them in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/scan_test.rb
@DemetrisChr DemetrisChr merged commit 3dffd03 into couchbase:main May 28, 2026
83 of 84 checks passed
@DemetrisChr DemetrisChr deleted the RCBC-535-minitest-6 branch May 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants