Skip to content

RCBC-535: Upgrade to Minitest 6 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DemetrisChr merged 1 commit into from
May 28, 2026
Merged

RCBC-535: Upgrade to Minitest 6 #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ group :development do
gem "heckle"
gem "irb"
# TODO(SA): review https://minite.st/docs/History_rdoc.html#label-6.0.0+-2F+2025-12-17
gem "minitest", "< 6.0"
gem "minitest", "~> 6.0"
gem "minitest-mock"
gem "minitest-reporters"
gem "mutex_m"
gem "opentelemetry-metrics-sdk", "~> 0.11.2"
Expand Down
6 changes: 0 additions & 6 deletions test/scan_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ def test_sampling_scan_batch_byte_limit
end

def test_range_scan_concurrency
skip("Skipped until CXXCBC-345 is resolved")

CONCURRENCY_VALUES.each do |c|
expected_ids = (0..9).map { |i| "#{@shared_prefix}-1#{i}" } + (0..9).map { |i| "#{@shared_prefix}-2#{i}" }
scan_result = @collection.scan(
Expand All @@ -268,8 +266,6 @@ def test_range_scan_concurrency
end

def test_prefix_scan_concurrency
skip("Skipped until CXXCBC-345 is resolved")

CONCURRENCY_VALUES.each do |c|
expected_ids = (0..9).map { |i| "#{@shared_prefix}-1#{i}" }
scan_result = @collection.scan(PrefixScan.new("#{@shared_prefix}-1"),
Expand All @@ -279,8 +275,6 @@ def test_prefix_scan_concurrency
end

def test_sampling_scan_concurrency
skip("Skipped until CXXCBC-345 is resolved")

CONCURRENCY_VALUES.each do |c|
Comment thread
DemetrisChr marked this conversation as resolved.
limit = 20
scan_result = @collection.scan(SamplingScan.new(limit), Options::Scan.new(concurrency: c, mutation_state: @mutation_state))
Expand Down
Loading