acc: run run_as/job_default locally on all clouds#5730
Open
radakam wants to merge 2 commits into
Open
Conversation
Flip run_as/job_default to Local=true so it runs against the local testserver in addition to cloud. The only divergence was run_as after a redeploy that drops it: the real Jobs reset API treats run_as as sticky and keeps the previously configured identity when new_settings omits it, while the fake cleared it. Mirror the backend so an unset run_as preserves the prior value, matching the cloud golden.
Collaborator
Integration test reportCommit: 5dffc78
21 interesting tests: 13 SKIP, 7 KNOWN, 1 RECOVERED
Top 4 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running this acceptance test locally (not just on cloud) makes it faster and free to run in CI/dev against the testserver.
Changes
run_as/job_defaulttoLocal = true.libs/testserver/jobs.go), mirror cloud's stickyrun_as: onjobs/reset, keep the previous value whennew_settingsomits it (the only local/cloud divergence).Tests
run_as/job_defaultnow runs on both local and cloud against one golden, no regressions.