Skip to content

acc: run run_as/job_default locally on all clouds #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radakam merged 2 commits into from
Jun 26, 2026
+10 −2
Merged

acc: run run_as/job_default locally on all clouds #5730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877483e
acc: run run_as/job_default locally on all clouds
radakam Jun 25, 2026
5dffc78
acc: clarify run_as sticky-reset comment as a known cloud quirk
radakam Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acceptance/bundle/run_as/job_default/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion acceptance/bundle/run_as/job_default/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Badness = "run_as is still set even though it's not in bundle and not in reset request"
Ignore = [".databricks/.gitignore"]

Local = false
Local = true
Cloud = true
RecordRequests = true

Expand Down
8 changes: 8 additions & 0 deletions libs/testserver/jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ func (s *FakeWorkspace) JobsReset(req Request) Response {
return Response{StatusCode: 403, Body: "{}"}
}

// Known cloud quirk (see the test's Badness note): jobs/reset is a full
// replace, but omitting run_as from new_settings does NOT clear it — cloud
// keeps the previously configured identity. Mirror that so the local
// testserver matches cloud against one golden.
if request.NewSettings.RunAs == nil {
request.NewSettings.RunAs = prevjob.Settings.RunAs
}

s.Jobs[jobId] = jobs.Job{
JobId: jobId,
CreatorUserName: prevjob.CreatorUserName,
Expand Down
Loading