Skip to content

Add German translation - #1408

Merged
mlinksva merged 3 commits into
github:gh-pagesfrom
Knocklive:gh-pages
Nov 17, 2026
Merged

mlinksva merged 3 commits into
github:gh-pagesfrom
Knocklive:gh-pages

Conversation

@Knocklive

Copy link
Copy Markdown
Contributor

Adds a German translation following TRANSLATING.md: UI, rules, all license summaries and the four prose pages. License texts are not translated.

Also sorts the languages list alphabetically (after en). Happy to revert that if you prefer.

spec/i18n_spec.rb passes and the site builds locally. The first draft was AI-assisted and then reviewed by me. Corrections are welcome.

Copilot AI adaptive review requested due to automatic review settings November 8, 2026 12:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A moderate issue remains because the single-quoted internal link bypasses the layout’s base-path rewriting and may navigate German users to the wrong license URL.

1 open issue
What changed in this PR

Adds German localization across the site, including UI strings, rule descriptions, license summaries, and four prose pages. German is also registered in the language selector, with non-English languages alphabetized.

Changes:

  • Adds German translations for interface text, rules, license summaries, and guidance pages.
  • Preserves the original English license texts.
  • Registers de in _config.yml and updates language ordering.
  • Follow-up needed for one internal-link quoting issue and one German phrasing nit.
File Summary
i18n/​de/​non-software.md German non-software licensing guidance.
i18n/​de/​no-permission.md German no-license guidance. Nit (1 vote): improve the phrasing around contributors holding their own copyrights.
i18n/​de/​community.md German community guidance page.
i18n/​de/​about.md German About page.
_data/​i18n/​de/​ui.yml German interface and page strings.
_data/​i18n/​de/​rules.yml German rule labels and descriptions.
_data/​i18n/​de/​licenses.yml German license summaries and application guidance. Moderate (2 votes): change the affected internal link to the double-quoted form so localization and base-path rewriting apply.
_config.yml Registers German and alphabetizes the language selector entries.

Review effort: Lite (auto)

Comment thread _data/i18n/de/licenses.yml Resolved
Updated the description for the CC BY-SA 4.0 license to correct formatting and ensure clarity.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mlinksva
mlinksva merged commit 58e7062 into github:gh-pages Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants