Skip to content

Address review comments

f45eca7
Select commit
Loading
Failed to load commit list.
Merged

Rust: Add reverse post-update flow steps #19106

Address review comments
f45eca7
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / CodeQL completed Mar 26, 2025 in 3s

6 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 6 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 2 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 230 in rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for preservesValue, but the QLDoc mentions set_data

Check warning on line 360 in rust/ql/lib/codeql/rust/dataflow/internal/SsaImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
.