JavaScript: Add support for indexing additional SAP related JSON files#19117
Merged
asgerf merged 3 commits intogithub:mainfrom Mar 31, 2025
Merged
JavaScript: Add support for indexing additional SAP related JSON files#19117asgerf merged 3 commits intogithub:mainfrom
asgerf merged 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request extends the extractor functionality to automatically index additional SAP-related JSON files.
- Updated Javadoc comments in AutoBuild.java to document the new JSON file types.
- Added new file filters in the setupFilters() method for xs-app.json, *.view.json, and manifest.json.
Files not reviewed (4)
- javascript/extractor/tests/ui5/input/test.view.json: Language not supported
- javascript/extractor/tests/ui5/output/trap/test.view.json.trap: Language not supported
- javascript/extractor/tests/xsjs/input/xs-app.json: Language not supported
- javascript/extractor/tests/xsjs/output/trap/xs-app.json.trap: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
erik-krogh
approved these changes
Mar 26, 2025
Contributor
erik-krogh
left a comment
erik-krogh
left a comment
There was a problem hiding this comment.
LGTM.
A DCA evaluation shows some new files extracted, but definitely not an overwhelming amount.
I'm not sure why the language tests aren't running in the CI though?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automatic extraction for a few additional
JSONformatted files:*.view.jsonfiles - used by SAP's UI5 framework.xs-app.jsonfiles - used by SAP's XSJS frameworkmanifest.jsonfiles - used by a number of different frameworks, including Chrome Extensions and SAP's UI5 frameworkThese files are used by the queries in https://github.com/advanced-security/codeql-sap-js.