Skip to content

Update protocol version and refine working directory handling in chat and session states - #327569

Merged
DonJayamanne merged 2 commits into
mainfrom
don/isolated-kite
Jul 28, 2026
Merged

Update protocol version and refine working directory handling in chat and session states#327569
DonJayamanne merged 2 commits into
mainfrom
don/isolated-kite

Conversation

@DonJayamanne

@DonJayamanne DonJayamanne commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 27, 2026 03:07
@DonJayamanne DonJayamanne self-assigned this Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines Agent Host working-directory semantics by replacing per-chat primaries with an immutable session-level first directory.

Changes:

  • Adds the immutablePrimary capability.
  • Removes primaryWorkingDirectory from chat/session APIs and projections.
  • Updates related documentation.
Show a summary per file
File Description
src/vs/platform/agentHost/node/claude/CONTEXT.md Updates Claude session metadata documentation.
src/vs/platform/agentHost/common/state/sessionState.ts Removes primary-directory projections.
src/vs/platform/agentHost/common/state/protocol/channels-session/state.ts Documents immutable session roots.
src/vs/platform/agentHost/common/state/protocol/channels-session/commands.ts Removes session primary parameters.
src/vs/platform/agentHost/common/state/protocol/channels-session/actions.ts Updates removal semantics.
src/vs/platform/agentHost/common/state/protocol/channels-root/state.ts Introduces immutablePrimary.
src/vs/platform/agentHost/common/state/protocol/channels-chat/state.ts Removes chat primary state.
src/vs/platform/agentHost/common/state/protocol/channels-chat/commands.ts Removes chat primary creation parameters.

Review details

  • Files reviewed: 8/8 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread src/vs/platform/agentHost/node/claude/CONTEXT.md
@DonJayamanne
DonJayamanne marked this pull request as ready for review July 27, 2026 21:41
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@TylerLeonhardt

Matched files:

  • src/vs/platform/agentHost/node/claude/CONTEXT.md

@github-actions

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 1e53f489 Current: 2861c66e

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (8)

agentSessionsViewer/ApprovalRow2Lines/Dark

current

agentSessionsViewer/ApprovalRow2Lines/Light

current

agentSessionsViewer/ApprovalRow3Lines/Dark

current

agentSessionsViewer/ApprovalRow3Lines/Light

current

agentSessionsViewer/ApprovalRow4Lines/Dark

current

agentSessionsViewer/ApprovalRow4Lines/Light

current

agentSessionsViewer/ApprovalRow3LongLines/Dark

current

agentSessionsViewer/ApprovalRow3LongLines/Light

current

@DonJayamanne
DonJayamanne merged commit 60d2f89 into main Jul 28, 2026
29 checks passed
@DonJayamanne
DonJayamanne deleted the don/isolated-kite branch July 28, 2026 00:26
@vs-code-engineering vs-code-engineering Bot added this to the 1.132.0 milestone Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants