Skip to content

sessions: Clarify the Environment picker management label - #344326

Merged
Christof Marti (chrmarti) merged 1 commit into
release/1.144from
chrmarti/environment-picker-manage-label
Oct 26, 2026
Merged

Christof Marti (chrmarti) merged 1 commit into
release/1.144from
chrmarti/environment-picker-manage-label

Conversation

@chrmarti

@chrmarti Christof Marti (chrmarti) commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Rename Manage... in the Environment picker to Manage Remote Environments....
  • Align the setting description and chat/Remotes accessibility help with the new label.
  • Preserve the command, visibility gates, selected environment, and per-host Manage submenus.

Rebased onto origin/release/1.144 at 62620115296 to avoid the unrelated chat-move test regression introduced on main by #344057 (13832cc4487). The diff remains the same six-file label-only change. Follow-up to the release backports #344266 and #344313; related to #344263.

Validation

  • npm run build-fast -- --client-only - passed after rebasing onto release/1.144.
  • Focused picker and accessibility tests on release/1.144 - 79 passing:
.\scripts\test.bat --run src\vs\sessions\contrib\chat\test\browser\sessionEnvironmentPicker.test.ts --run src\vs\sessions\contrib\chat\test\browser\sessionsChatAccessibilityHelp.test.ts --reporter dot
  • Release-diff ESLint and hygiene - 6 files passed; whitespace check passed:
$files = @(git diff --name-only origin/release/1.144...HEAD -- '*.ts')
npm run eslint -- $files
node build\hygiene.ts $files
git diff --check origin/release/1.144...HEAD

This is a string-only change; full type-check and smoke/integration suites were not run.

Manual check

Open the Environment picker, select Manage Remote Environments..., and verify Remotes management opens without changing the selected environment.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 15:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently update localized wording and test expectations while preserving existing behavior, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Clarifies the Agents Window’s Environment picker by renaming Manage... to Manage Remote Environments..., following the earlier remote-management label updates.

Changes:

  • Updates the localized picker label without changing its command, visibility gates, selection behavior, or per-host submenus.
  • Aligns the setting description and chat/Remotes accessibility help.
  • Updates existing picker and accessibility test expectations.
File Description
src/​vs/​sessions/​contrib/​providers/​remoteAgentHost/​electron-browser/​remotes.contribution.ts Aligns Remotes accessibility help with the new label.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​sessionsChatAccessibilityHelp.test.ts Updates the expected accessibility help text.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​sessionEnvironmentPicker.test.ts Updates picker label and visibility assertions.
src/​vs/​sessions/​contrib/​chat/​browser/​sessionsChatAccessibilityHelp.ts Uses the new label in chat accessibility help.
src/​vs/​sessions/​contrib/​chat/​browser/​sessionEnvironmentPicker.ts Renames the management action.
src/​vs/​sessions/​contrib/​chat/​browser/​chat.contribution.ts Aligns the setting description.

Review effort: Balanced

@chrmarti
Christof Marti (chrmarti) marked this pull request as draft October 26, 2026 16:01
Rename Manage... to Manage Remote Environments... and align accessibility help, setting documentation, and label assertions without changing command behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: ff05b50d Current: c7a611a4

Changed (27)

sessions/agentsWindowExtensionsWidget/AgentsWindowExtensions/Light
Before After
before after
sessions/agentsWindowExtensionsWidget/AgentsWindowExtensionsSuggested/Light
Before After
before after
sessions/agentsWindowExtensionsWidget/AgentsWindowExtensionsNarrow/Light
Before After
before after
sessions/agentsWindowExtensionsWidget/AgentsWindowExtensionsSearch/Light
Before After
before after
sessions/remotes/remotesWidget/ConnectionError/Light
Before After
before after
sessions/remotes/remotesWidget/ConnectionRetry/Light
Before After
before after
sessions/remotes/remotesWidget/ShortEmpty/Light
Before After
before after
sessions/remotes/remotesWidget/ShortEmptyNarrow/Light
Before After
before after
sessions/remotes/remotesWidget/Environments/Light
Before After
before after
sessions/remotes/remotesWidget/EnvironmentActions/Light
Before After
before after
sessions/remotes/remotesWidget/RefreshingTunnels/Light
Before After
before after
sessions/remotes/remotesWidget/TunnelDiscoveryFailure/Light
Before After
before after
sessions/remotes/remotesWidget/TunnelSignIn/Light
Before After
before after
sessions/remotes/remotesWidget/TunnelSigningIn/Light
Before After
before after
sessions/remotes/remotesWidget/TunnelSignInNarrow/Light
Before After
before after
sessions/remotes/remotesWidget/EnvironmentsNarrow/Light
Before After
before after
sessions/remotes/remotesWidget/EnvironmentsEmpty/Light
Before After
before after
sessions/remotes/remotesWidget/EnvironmentsWarning/Light
Before After
before after
sessions/remotes/remotesWidget/Table/Light
Before After
before after
sessions/remotes/remotesWidget/Wide/Light
Before After
before after
sessions/remotes/remotesWidget/Windows/Light
Before After
before after
sessions/remotes/remotesWidget/Narrow/Light
Before After
before after
sessions/remotes/remotesWidget/Empty/Light
Before After
before after
sessions/remotes/remotesWidget/EmptyWindows/Light
Before After
before after
sessions/remotes/remotesWidget/EmptyNarrow/Light
Before After
before after
sessions/remotes/remotesWidget/RefreshWarnings/Light
Before After
before after
sessions/remotes/remotesWidget/EmptyRefreshWarnings/Light
Before After
before after

Added (1)

sessions/remotes/remotesWidget/InlineActions/Light

current

@chrmarti
Christof Marti (chrmarti) merged commit 2819e0a into release/1.144 Oct 26, 2026
46 checks passed
@chrmarti
Christof Marti (chrmarti) deleted the chrmarti/environment-picker-manage-label branch October 26, 2026 16:45
@vs-code-engineering vs-code-engineering Bot added this to the 1.144.0 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants