Repository navigation
sessions: Clarify the Environment picker management label - #344326
Merged
Christof Marti (chrmarti) merged 1 commit intoOct 26, 2026
Merged
Christof Marti (chrmarti) merged 1 commit into
Christof Marti (chrmarti) merged 1 commit into
Conversation
Federico Brancasi (federicobrancasi)
previously approved these changes
Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently update localized wording and test expectations while preserving existing behavior, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Clarifies the Agents Window’s Environment picker by renaming Manage... to Manage Remote Environments..., following the earlier remote-management label updates.
Changes:
- Updates the localized picker label without changing its command, visibility gates, selection behavior, or per-host submenus.
- Aligns the setting description and chat/Remotes accessibility help.
- Updates existing picker and accessibility test expectations.
| File | Description |
|---|---|
src/vs/sessions/contrib/providers/remoteAgentHost/electron-browser/remotes.contribution.ts |
Aligns Remotes accessibility help with the new label. |
src/vs/sessions/contrib/chat/test/browser/sessionsChatAccessibilityHelp.test.ts |
Updates the expected accessibility help text. |
src/vs/sessions/contrib/chat/test/browser/sessionEnvironmentPicker.test.ts |
Updates picker label and visibility assertions. |
src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts |
Uses the new label in chat accessibility help. |
src/vs/sessions/contrib/chat/browser/sessionEnvironmentPicker.ts |
Renames the management action. |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts |
Aligns the setting description. |
Review effort: Balanced
Benjamin Christopher Simmonds (benibenj)
previously approved these changes
Oct 26, 2026
Christof Marti (chrmarti)
marked this pull request as draft
October 26, 2026 16:01
Rename Manage... to Manage Remote Environments... and align accessibility help, setting documentation, and label assertions without changing command behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Christof Marti (chrmarti)
dismissed stale reviews from Benjamin Christopher Simmonds (benibenj) and Federico Brancasi (federicobrancasi)
via
October 26, 2026 16:25
0233070
Christof Marti (chrmarti)
force-pushed
the
chrmarti/environment-picker-manage-label
branch
from
October 26, 2026 16:25
f59e282 to
0233070
Compare
Christof Marti (chrmarti)
marked this pull request as ready for review
October 26, 2026 16:27
Christof Marti (chrmarti)
enabled auto-merge
October 26, 2026 16:28
Contributor
Screenshot ChangesBase: Changed (27)Added (1) |
Federico Brancasi (federicobrancasi)
approved these changes
Oct 26, 2026
Christof Marti (chrmarti)
deleted the
chrmarti/environment-picker-manage-label
branch
October 26, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto
origin/release/1.144at62620115296to avoid the unrelated chat-move test regression introduced on main by #344057 (13832cc4487). The diff remains the same six-file label-only change. Follow-up to the release backports #344266 and #344313; related to #344263.Validation
npm run build-fast -- --client-only- passed after rebasing onto release/1.144.This is a string-only change; full type-check and smoke/integration suites were not run.
Manual check
Open the Environment picker, select Manage Remote Environments..., and verify Remotes management opens without changing the selected environment.