NO-JIRA: Revert "OCPBUGS-87828: Scope minted AWS IAM policies to cluster-owned resources"

[nrb]

This reverts commit f7565c6.

Manual backport of #1057

[openshift-ci-robot]

@nrb: This pull request explicitly references no jira issue.

Details

In response to this:

This reverts commit f7565c6.

Manual backport of #1057

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b9382b5b-c129-44f2-804b-b71826ad5f2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.88%. Comparing base (d6c4c19) to head (952d248).

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #1059      +/-   ##
================================================
- Coverage         47.13%   46.88%   -0.25%     
================================================
  Files                98       98              
  Lines             12606    12558      -48     
================================================
- Hits               5942     5888      -54     
- Misses             6008     6015       +7     
+ Partials            656      655       -1     

Files with missing lines	Coverage Δ
pkg/aws/actuator/actuator.go	67.79% <100.00%> (-1.46%)	⬇️
pkg/aws/utils.go	83.87% <ø> (-2.25%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nrb]

/override ci/prow/security

permafailing

[openshift-ci]

@nrb: nrb unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/security

permafailing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[2uasimojo]

/override ci/prow/security
/approve

[openshift-ci]

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/override ci/prow/security
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[newtonheath]

@2uasimojo @dlom can you poke this?

[2uasimojo]

/test e2e-hypershift

[dlom]

/override ci/prow/security

[dlom]

/test e2e-hypershift

[openshift-ci]

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

Details

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dlom]

/test e2e-hypershift

[dlom]

/label backport-risk-assessed

[dlom]

/label jira/valid-bug

[openshift-ci]

@dlom: The label(s) jira/valid-bug cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-staff-engineers, openshift-release-oversight, openshift-sustaining-engineers

Details

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dlom]

@2uasimojo are you one of the following by chance? openshift-patch-managers, openshift-staff-engineers, openshift-release-oversight, openshift-sustaining-engineers

[dlom]

/verified by everyone at this point I think

[dlom]

/lgtm

[openshift-ci-robot]

@dlom: This PR has been marked as verified by everyone at this point I think.

Details

In response to this:

/verified by everyone at this point I think

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom, nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dlom]

/override jira/valid-bug

[openshift-ci]

@dlom: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• jira/valid-bug

Only the following failed contexts/checkruns were expected:

• CodeRabbit
• ci/prow/coverage
• ci/prow/e2e-aws-cco-parallel
• ci/prow/e2e-aws-ovn
• ci/prow/e2e-hypershift
• ci/prow/e2e-upgrade
• ci/prow/images
• ci/prow/security
• ci/prow/unit
• ci/prow/verify
• ci/prow/verify-deps
• pull-ci-openshift-cloud-credential-operator-master-coverage
• pull-ci-openshift-cloud-credential-operator-master-e2e-aws-cco-parallel
• pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
• pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
• pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
• pull-ci-openshift-cloud-credential-operator-master-images
• pull-ci-openshift-cloud-credential-operator-master-security
• pull-ci-openshift-cloud-credential-operator-master-unit
• pull-ci-openshift-cloud-credential-operator-master-verify
• pull-ci-openshift-cloud-credential-operator-master-verify-deps
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dlom]

/test e2e-hypershift

[openshift-ci]

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	952d248	link	true	/test e2e-hypershift
ci/prow/security	952d248	link	true	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.