Skip to content

i18n(ja): unescape HTML entities that render literally in code/text - #23409

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-html-entities
Aug 5, 2026
Merged

i18n(ja): unescape HTML entities that render literally in code/text#23409
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-html-entities

Conversation

@yahonda

@yahonda yahonda commented Aug 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Reported on the ja pd-control page: the heading rendered config [show | set &#x3C;option> &#x3C;value> | placement-rules] — the literal entity string &#x3C; was shown instead of <.

Root cause: the translation pipeline HTML-escaped some characters to numeric/named entities. Inside code spans, tables, and plain text these entities are not decoded, so the reader sees the raw entity. The English source uses none of these entity forms (they are all literal characters there), so this is a Japanese-only artifact.

Fix — restore the literal characters to match the English source:

entity count
&#x3C; < 112
&#x26; & 218
&quot; " 518
&#39; ' 111

Left untouched: &lt; / &gt; / &amp; — the English source also uses these as legitimate escapes in specific contexts, so they are not artifacts. Verified none of the four converted entities sit inside a raw HTML tag/attribute (where conversion could break markup).

Scope: 196 files.

Stacked on #23325 (heading-anchor alignment). Both PRs touch the same pd-control.md heading lines — #23325 fixes the anchors ({#…x3c…}{#…}), this PR fixes the visible text (&#x3C;<); together the headings are fully correct. Review/merge after #23325; until then this PR's diff also shows #23325's changes.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)

What is the related PR or file link(s)?

@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3247fdb-9c5d-4c17-aa3f-6dde32f43b73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2026
@yahonda
yahonda marked this pull request as ready for review August 3, 2026 05:04
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 3, 2026
@qiancai

qiancai commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, could you please resolve conflicts in this PR? Thanks.

@yahonda
yahonda force-pushed the i18n-ja-fix-html-entities branch from 7983c68 to 127d230 Compare August 4, 2026 00:41
@yahonda

yahonda commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Rebased.

@qiancai

qiancai commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, sorry to bother you again. It looks like there are new conflicts in this PR. Could you please take a look? Thanks!

@yahonda
yahonda force-pushed the i18n-ja-fix-html-entities branch from 127d230 to a5e17fe Compare August 4, 2026 02:58
@yahonda

yahonda commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Rebased.

The translation pipeline HTML-escaped some characters (<, &, ", ') to numeric
or named entities. Inside code spans, tables, and plain text these entities are
NOT decoded, so readers see the literal entity string (e.g. the pd-control
heading rendered `config [show | set &#x3C;option> &#x3C;value> ...]`).

Restore the literal characters, matching the English source (which uses none of
these entity forms):

- &#x3C; -> <   (112)
- &#x26; -> &   (218)
- &quot; -> "   (518)
- &pingcap#39;  -> '   (111)

Left untouched: &lt; / &gt; / &amp;, which the English source also uses as
legitimate escapes in specific contexts.

Stacked on pingcap#23325 (heading-anchor alignment) because both touch the same
pd-control.md heading lines; pingcap#23325 fixes the anchors, this fixes the visible
@yahonda
yahonda force-pushed the i18n-ja-fix-html-entities branch from a5e17fe to 5acc23c Compare August 4, 2026 06:35
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-05 12:23:24.817723221 +0000 UTC m=+2617190.853818277: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit b51562e into pingcap:i18n-ja-release-8.5 Aug 5, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants