i18n(ja): unescape HTML entities that render literally in code/text - #23409
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@yahonda, could you please resolve conflicts in this PR? Thanks. |
7983c68 to
127d230
Compare
|
Rebased. |
|
@yahonda, sorry to bother you again. It looks like there are new conflicts in this PR. Could you please take a look? Thanks! |
127d230 to
a5e17fe
Compare
|
Rebased. |
The translation pipeline HTML-escaped some characters (<, &, ", ') to numeric or named entities. Inside code spans, tables, and plain text these entities are NOT decoded, so readers see the literal entity string (e.g. the pd-control heading rendered `config [show | set <option> <value> ...]`). Restore the literal characters, matching the English source (which uses none of these entity forms): - < -> < (112) - & -> & (218) - " -> " (518) - &pingcap#39; -> ' (111) Left untouched: < / > / &, which the English source also uses as legitimate escapes in specific contexts. Stacked on pingcap#23325 (heading-anchor alignment) because both touch the same pd-control.md heading lines; pingcap#23325 fixes the anchors, this fixes the visible
a5e17fe to
5acc23c
Compare
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Reported on the ja pd-control page: the heading rendered
config [show | set <option> <value> | placement-rules]— the literal entity string<was shown instead of<.Root cause: the translation pipeline HTML-escaped some characters to numeric/named entities. Inside code spans, tables, and plain text these entities are not decoded, so the reader sees the raw entity. The English source uses none of these entity forms (they are all literal characters there), so this is a Japanese-only artifact.
Fix — restore the literal characters to match the English source:
<<&&""''Left untouched:
</>/&— the English source also uses these as legitimate escapes in specific contexts, so they are not artifacts. Verified none of the four converted entities sit inside a raw HTML tag/attribute (where conversion could break markup).Scope: 196 files.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?