Delete tkinter.{Grid,Pack,Place}.content#15763
Merged
Merged
Conversation
JelleZijlstra
approved these changes
May 11, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.15+ added several things named
contentorfoo_contentto tkinter. They should be just like things namedslavesorfoo_slaves. This PR makes them consistent by deleting aliases namedcontentwhere aliases namedslavesdon't exist.I intentionally omitted the
slavesaliases earlier. Nobody has complained here about it or other similar aliases. Basically,tkinter.Grid.content(widget)is just likewidget.grid_content(), except that nobody uses thetkinter.Grid.content(widget)form.The main reason for not having
slavesandcontentaliases is that they confuse type checkers in some complex situations. For example, we already silence a bunch of errors in typeshed when doing multiple inheritance, and for whatever reason, someone might want to use similar multiple inheritance outside typeshed to create some kind of custom widget.Some history:
slavesaliases commented out.slavesaliases.contentaliases were added even though there are noslavesaliases.