fix(workflows): cap get-secrets histogram buckets in MetricViews#23030
Draft
pkcll wants to merge 1 commit into
Draft
fix(workflows): cap get-secrets histogram buckets in MetricViews#23030pkcll wants to merge 1 commit into
pkcll wants to merge 1 commit into
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
platform_engine_get_secrets_duration_ms used OTel default 16 buckets; add an explicit 8-bucket view next to the other platform_engine views. Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
platform-engine-get-secrets-metricviews
branch
from
a7a9347 to
e243d4d
Compare
3 tasks
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricViews()forplatform_engine_get_secrets_duration_mswith 7 explicit boundaries (8 Prometheus buckets including+Inf), down from the OTel default of 16 buckets.platform_engine_*histogram views wired viashell.go→beholder.Config.MetricViews.TestMetricViews_getSecretsDurationBuckets.Motivation
High-cardinality CRE workflow nodes accumulate series from histogram
lelabels × workflow count. This instrument had no custom view (unlike the other platform_engine histograms inmonitoring.go).Dashboard impact (Medium)
Capabilities dashboard (
Capabilities.json, 13 zones) uses:histogram_quantile(0.50, …platform_engine_get_secrets_duration_ms_milliseconds_bucket…)histogram_quantile(0.90, …)Fewer buckets may shift p50/p90 slightly vs default boundaries. Validate on staging after deploy.
Test plan
go test ./core/services/workflows/monitoring/ -run TestMetricViews_getSecretsDurationBucketsRelated