Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions core/services/workflows/monitoring/metric_views_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package monitoring_test

import (
"context"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/otel/metric"
sdkmetric "go.opentelemetry.io/otel/sdk/metric"
"go.opentelemetry.io/otel/sdk/metric/metricdata"

"github.com/smartcontractkit/chainlink/v2/core/services/workflows/monitoring"
)

func TestMetricViews_getSecretsDurationBuckets(t *testing.T) {
t.Parallel()

wantBoundaries := []float64{0, 10, 50, 100, 250, 500, 1000}

reader := sdkmetric.NewManualReader()
mp := sdkmetric.NewMeterProvider(
sdkmetric.WithReader(reader),
sdkmetric.WithView(monitoring.MetricViews()...),
)
t.Cleanup(func() { _ = mp.Shutdown(context.Background()) })

hist, err := mp.Meter("test").Int64Histogram(
"platform_engine_get_secrets_duration_ms",
metric.WithUnit("ms"),
)
require.NoError(t, err)
hist.Record(context.Background(), 75)

var rm metricdata.ResourceMetrics
require.NoError(t, reader.Collect(context.Background(), &rm))

require.Len(t, rm.ScopeMetrics, 1)
require.Len(t, rm.ScopeMetrics[0].Metrics, 1)
require.Equal(t, "platform_engine_get_secrets_duration_ms", rm.ScopeMetrics[0].Metrics[0].Name)

data, ok := rm.ScopeMetrics[0].Metrics[0].Data.(metricdata.Histogram[int64])
require.True(t, ok)
require.Len(t, data.DataPoints, 1)
assert.Equal(t, wantBoundaries, data.DataPoints[0].Bounds)
assert.Len(t, data.DataPoints[0].Bounds, 7, "expected 7 boundaries (8 Prometheus buckets including +Inf)")
}
7 changes: 7 additions & 0 deletions core/services/workflows/monitoring/monitoring.go
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,13 @@ func MetricViews() []sdkmetric.View {
Boundaries: []float64{0, 0.001, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2, 5, 10, 30, 60},
}},
),
// Default OTel buckets (16) for this instrument; Capabilities dashboards use p50/p90.
sdkmetric.NewView(
sdkmetric.Instrument{Name: "platform_engine_get_secrets_duration_ms"},
sdkmetric.Stream{Aggregation: sdkmetric.AggregationExplicitBucketHistogram{
Boundaries: []float64{0, 10, 50, 100, 250, 500, 1000},
}},
),
}
}

Expand Down
Loading