Repository navigation
js: Use UTF-8 byte length for metadata string prefixes - #859
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joncinque
approved these changes
Oct 9, 2026
Contributor
|
Thanks for finding and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateTokenMetadataInstructioninclients/jswrites each borsh string length prefix using the JavaScript string length (UTF-16 code units) but then appends the UTF-8 bytes fromTextEncoder. For any name, symbol or URI containing non-ASCII characters (e.g.é,☀, emoji), the prefix is shorter than the actual byte length, so the program misreads the instruction data. With the nameCafé Staking ☀the program reads a garbage length for the next field and aborts:This affects both
@solana/spl-single-pooland@solana/spl-single-pool-classic, since the legacy client calls the same builder. The Rustupdate_token_metadatabuilder uses borsh and is not affected.Summary of Changes
mainwith the panic above and passes with this change.I used an AI assistant (Claude) while preparing this. I reproduced the issue and checked the fix and tests myself.
🤖 Generated with Claude Code