Skip to content

GH-1998: Add explanation and plugin consistency checks - #2066

Merged
BoykoAlex merged 1 commit into
spring-projects:mainfrom
patbaumgartner:pr/a4-consistency-checks
Oct 28, 2026
Merged

BoykoAlex merged 1 commit into
spring-projects:mainfrom
patbaumgartner:pr/a4-consistency-checks

Conversation

@patbaumgartner

@patbaumgartner patbaumgartner commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Fixes gh-1998

Summary

  • Add deterministic consistency checks and tests for the diagnostic explanation playbooks and plugin configuration (claude-plugins/tools).
  • Add the missing MODEL_ATTRIBUTE_NAMES coverage-table entry and link its playbook to the Spring API docs.
  • Whitelist the intentional HTTP URL used by the policy test.

Stack

First of five stacked PRs. Merge order: #2066 → #2067 → #2068 → #2069 → #2070. Each PR adds exactly one commit on top of its predecessor; until the predecessor is merged, please review only the last commit.

Validation

  • npm --prefix claude-plugins/tools test (18 tests)
  • node claude-plugins/tools/check-explanations.mjs --require-all --todo (71/71)
  • ./nohttp.sh

…oks and plugin config

Fixes spring-projectsgh-1998

Signed-off-by: Patrick Baumgartner <contact@patbaumgartner.com>
@patbaumgartner
patbaumgartner force-pushed the pr/a4-consistency-checks branch from c20bc4d to e39902e Compare October 25, 2026 10:26
@martinlippert martinlippert added this to the 5.5.0.RELEASE milestone Oct 26, 2026
@BoykoAlex

BoykoAlex commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

@patbaumgartner I'd like a readme.md under tools folder a quick guide what the checks do and how to run the checks. (I guess these checks to be wired to the CI in the future?)

Were you thinking us merging these without much changes perhaps not to break the PR sequence? We can do that now and let you do changes on top of all these PRs. Please let us know we'd like to make it as convenient for you as possible.

@patbaumgartner

Copy link
Copy Markdown
Contributor Author

@BoykoAlex - I like the idea of the readme.md in the tools' folder, and yes, CI checks would be great.

If you prefer one single PR but with separate commits, we can do that and work on this one until it gets merged. There are quite a few changes. Merging them at once is a risk. That's why I mentioned that we can do them one by one, and I always rebase the next one.

@patbaumgartner

patbaumgartner commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

@martinlippert, thanks for the label for:claude. I want to make it agnostic to Claude Code and support many other tools too ;)

Suggestion: for:agent

@martinlippert

Copy link
Copy Markdown
Member

@martinlippert, thanks for the label for:claude. I want to make it agnostic to Claude Code and support many other tools too ;)

Yeah, I know, but it is the label that we have at the moment for agents, since we started with Claude Code... :-)

Suggestion: for:agent

Yeah, makes sense. Let me change the label.

@martinlippert

Copy link
Copy Markdown
Member

Updated the label accordingly now... :-)

@BoykoAlex

Copy link
Copy Markdown
Contributor

I'll merge this one

@BoykoAlex
BoykoAlex merged commit 358458b into spring-projects:main Oct 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[claude code] implement consistency checks for markdown-based descriptions

3 participants