Repository navigation
GH-2030: Harden plugin install, launcher and hooks - #2067
Merged
BoykoAlex merged 3 commits intoOct 30, 2026
Merged
Conversation
…oks and plugin config Fixes spring-projectsgh-1998 Signed-off-by: Patrick Baumgartner <contact@patbaumgartner.com>
…ve refresh into a skill Fixes spring-projectsgh-2030 Signed-off-by: Patrick Baumgartner <contact@patbaumgartner.com>
patbaumgartner
force-pushed
the
pr/p4-install-launcher-hooks
branch
from
October 25, 2026 10:26
bd2bcc5 to
432057d
Compare
BoykoAlex
reviewed
Oct 28, 2026
BoykoAlex
left a comment
BoykoAlex
left a comment
Contributor
There was a problem hiding this comment.
The install.js and. launcher.js became rather large. I'd suggest two things:
-
Split the logic into modules. Keep
install.jsandlauncher.jsas thin entry points and move the cohesive pieces (download and proxy handling, locking, Java discovery, project directory resolution) into separate files. Most of the code is already written as small functions that take their environment as parameters, so this should be mostly mechanical. The exact structure is up to you. -
Add type checking to the JavaScript without moving to TypeScript. AI suggests
//@ts-checkbut i never used it. If 1 delivers good results maybe this is unnecessary
Signed-off-by: Alex Boyko <alex.boyko@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-2030
Summary
CLAUDE.md.Stack
Depends on #2066. Review commit
432057d91only. Merge order: #2066 → #2067 → #2068 → #2069 → #2070.Validation
npm --prefix claude-plugins/tools test(48 tests)node claude-plugins/tools/check-explanations.mjs --require-all --todo --links./nohttp.sh