test: migrate stats/base/dists/lognormal/pdf to ULP-based assertions - #14272
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N6nGZrFRdZCmZGiBjMnGtZ --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 14, 2026 23:40
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
Migrates the tests for
stats/base/dists/lognormal/pdffrom relative-tolerance testing to ULP (units in the last place) difference testing, per the tracking issue.Replaces the
delta/tol(EPS-based) comparisons intest/test.pdf.js,test/test.factory.js, andtest/test.native.jswith@stdlib/assert/is-almost-same-value.test/test.jsonly performs exact assertions and is left unchanged.The minimum required ULP bound was determined empirically by computing, for every non-
nullexpected value in each fixture set (1000 values per set), the exact minimum ULP difference between the observed and expected values, and then taking the maximum over the set. The JavaScript and factory code paths yielded identical maxima. The measured minimums are:positive_location550.0 * EPSnegative_location1050.0 * EPSlarge_variance300.0 * EPSMinimality was verified by re-running
test/test.pdf.jswith each bound decremented by one (799/1488/304), which fails exactly one assertion per fixture set; the values above are therefore the tightest bounds which pass.The test suite was run twice at these bounds to confirm deterministic results (no FMA/architecture-related flakiness).
The existing
expected[ i ] !== nullguard in each fixture loop is retained as-is, since it is not part of the tolerance idiom being migrated.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
The bounds for
test/test.native.jsmirror those measured for the JavaScript implementation. The native add-on was not built in the authoring environment, so those tests were skipped locally and the bounds are unverified against the C implementation; CI coverage for the native tests would confirm them.Other
test/test.js,test/test.pdf.js, andtest/test.factory.jsare green (3, 3014, and 3017 assertions, respectively, all passing, across two consecutive runs). ESLint (etc/eslint/.eslintrc.tests.js), the EditorConfig check, the filename lint, and commitlint are all clean for the changed files; the same checks were run against an already-migrated package (stats/base/dists/gamma/pdf) as a control.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, following the conventions established in already-merged ULP migration PRs (e.g. #14206, #14213). The ULP bounds were measured empirically, not guessed.
@stdlib-js/reviewers
Generated by Claude Code