Repository navigation
Conversation
Adds DEPLOY_BASE_IMAGES / DEPLOY_BUILD_BASE_IMAGES (runtime=image csv) to the webapp. The deployment initialize response carries the images for the deploy's runtime, and the CLI rewrites the Containerfile to build on them.
🦋 Changeset detectedLatest commit: fdf367a The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThe webapp parses per-runtime deploy and build image settings and returns matching images in deployment responses. Deployment initialization rejects native builds and clients that do not declare support when custom images are required. The CLI applies returned images when generating Containerfiles for standard deployments and rejects bundle deployments that require custom images. Containerfile generation uses runtime defaults when image fields are not configured. The changes also add API schemas, tests, self-hosting documentation, and release notes. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to Unset settings remain safe, and deployments without a configured runtime image continue using the CLI defaults. No actionable merge risk was identified in the reviewed changes. Security Architecture Review
Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. (1 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: allowing self-hosted instances to require deploy base images. Description check The description identifies the linked issue, explains the implementation and scope, documents testing, and summarizes the change. It omits the checklist and screenshots sections, but the required tech… Linked Issues check [ #5004] The webapp validates optional runtime-specific, digest-pinned image settings at startup. The deployment responses include resolvedbaseImages, and configured runtimes override the published …Out of Scope Changes check The changes stay within [ #5004]. They add instance environment parsing, deployment response fields, CLI image application and rejection handling, schemas, focused tests, release metadata, and self-hos…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
🧪 Generate unit tests (beta)
-
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Validate DEPLOY_BASE_IMAGES and DEPLOY_BUILD_BASE_IMAGES when the webapp starts: entries must name a known runtime and a digest-pinned image, with no duplicate runtimes. Invalid values fail startup instead of silently falling back to the published images. Honor the build-stage image when build extensions add image instructions: the build stage is created from the configured build image and the instructions are replayed on it, instead of being derived from the base with a toolchain install. Apply the server's base images on --from-bundle deploys by regenerating the bundle's Containerfile, and print the images in the deploy output. Docs: split the Node and Bun base image requirements, describe the validation rules and the paths the setting applies to.
Reject initialize-deployment requests from CLIs that cannot apply the instance's base images, so the setting is enforced rather than advisory. The CLI declares support on the paths that can honour it, and fails with a clear error on --native-build and --local-bundle, which cannot. Return the base images on the get-deployment response as well, so deploys that attach to an existing deployment build on them too. Validate image refs with one shared schema in core on both the server and the CLI: a single token pinned by digest. Reject the runtime alias node in favour of the concrete runtime keys, and report every invalid env entry in one error at startup. Build the custom build stage with the same customization block as the base stage, so instructions and package installs run in the same order.
…e set Native builds and local bundles cannot apply the instance's base images and never declared support, so the server was rejecting them with the message meant for outdated CLIs. Reject them with their own message on the server and drop the CLI-side checks that could never run. Docs: describe what the build stage uses without a build image entry, note that --from-bundle rewrites the Containerfile inside the bundle directory, and shorten the env table rows.
nicktrn
marked this pull request as ready for review
October 7, 2026 13:56
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # apps/webapp/app/env.server.ts
nicktrn
approved these changes
Oct 10, 2026
Merged
via the queue into
triggerdotdev:main
with commit Oct 10, 2026
93465d8
66 of 67 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5004
Lets a self-hosted operator require custom base images for every deploy to their instance, such as FIPS-validated or hardened Node images. Cloud never sets the variables, so nothing changes there.
baseImages; the CLI rewrites the Containerfile with them. A configured build image is also used when a project hasimage.instructions.--native-build,--local-bundleand--from-bundledeploys, are rejected with a clear error.Testing
apps/webapp/test/deployBaseImages.test.tsandpackages/cli-v3/src/deploy/buildImage.test.tscover the parsing, rejection and Containerfile cases. Typecheck, format and lint are clean.