Repository navigation
test: migrate Pages Router deploy exclusions to force gates - #98157
Merged
Merged
Conversation
Contributor
Tests PassedCommit: d83d167 |
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 2, 2026 00:13
8040de7 to
1cfbbb1
Compare
gnoff
marked this pull request as ready for review
September 2, 2026 00:17
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 2, 2026 00:20
1cfbbb1 to
7282d12
Compare
eps1lon
approved these changes
Sep 2, 2026
Comment on lines
+15
to
+17
| if (isNextDeploy) { | ||
| it('is excluded from deploy testing by @force-gate', () => {}) | ||
| } |
Member
There was a problem hiding this comment.
Why's this needed? Haven't seen this pattern anywhere else.
Comment on lines
+7
to
+8
| // TODO(deploy-test-completion): Re-enable this suite in deploy mode. | ||
| // The source only records that these assertions fail after deployment; the root cause is unknown. |
Member
There was a problem hiding this comment.
should this move the the gate as well? There are more (global as any).isNextDeploy not using force-gate.
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 3, 2026 18:36
7282d12 to
480364d
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 4, 2026 18:05
480364d to
75f47ea
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 4, 2026 20:32
75f47ea to
88e1320
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 8, 2026 15:00
88e1320 to
f03cdc4
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 8, 2026 23:32
f03cdc4 to
c24feff
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 9, 2026 02:41
c24feff to
e62f531
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 9, 2026 15:25
e62f531 to
0141b5b
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 9, 2026 15:45
0141b5b to
439aa72
Compare
gnoff
removed this pull request from stack #98373
September 9, 2026 15:46
gnoff
added this pull request to stack #98431
September 9, 2026 15:47
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
2 times, most recently
from
September 11, 2026 14:55
93bc6fb to
a4a6c45
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 11, 2026 15:10
a4a6c45 to
81f87ec
Compare
jamiboym
removed this pull request from stack #98431
September 28, 2026 20:23
jamiboym
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 28, 2026 20:23
81f87ec to
27dc706
Compare
jamiboym
changed the base branch from
jstory/deploy-tests/tooling
to
canary
September 28, 2026 20:23
jamiboym
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 28, 2026 20:35
27dc706 to
2271b36
Compare
jamiboym
changed the base branch from
canary
to
jstory/deploy-tests/tooling
September 28, 2026 20:35
jamiboym
added this pull request to stack #99381
September 28, 2026 20:35
jamiboym
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 28, 2026 23:50
2271b36 to
eed8964
Compare
gnoff
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 29, 2026 02:41
eed8964 to
a736f25
Compare
jamiboym
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
September 29, 2026 23:48
69fa18d to
4e71b9c
Compare
jamiboym
force-pushed
the
jstory/deploy-tests/pages-router
branch
from
October 1, 2026 15:56
4e71b9c to
d83d167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the remaining Pages Router, API route, i18n, custom route, rewrite, redirect, and error-page deployment exclusions to
@force-gateand remove theirskipDeployment/skippedcontrol flow. This stack is rooted at canary and independent of #98430; it preserves deployment coverage already enabled on canary.The custom-app-render and client-max-body-size files covered by #98994 and #98911 are omitted.
Verification
cargo metadatawithEPERM; full integration/deployment execution remains for CI.