You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: upgrade the visual reporter to React 19 - #1293
Step 3 of the visual reporter upgrade: React 18 → 19 (replaces Dependabot #1264).
Depends on #1292 (React Router 7), which depends on #1291 (Vite 6). Their commits are included here; after they are merged, this PR shows only the React 19 commit.
Remix 2 accepted only React 18; React Router 7 accepts React 18 and 19. The other UI packages accept React 19 (react-select 5.10: ^16.8 || … || ^19.0, react-icons 5.7: *).
These are development dependencies of the reporter: they build the static report UI. Users do not install them.
app/types/index.ts: with @types/react 19, useRef<T>(null) returns RefObject<T | null>, so CanvasDrawingProps.canvasRef allows null. The drawing hook already checks canvasRef.current for null.
Test
The built UI is pixel-identical: the demo report served on a fresh port and opened in headless Chrome (WebdriverIO), home view and comparison overlay: 0 different pixels compared with the Vite 5 / Remix build.
The react-select filters work: the Status dropdown opens with "All", "Passed" and "Failed"; "Passed" shows 19 cards and "Failed" 17. No browser console errors.
Reporter typecheck, pnpm test (1077 unit tests): pass. pnpm peers check: no React peer warning.
No changeset: development dependencies only, and the built UI does not change.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 3 of the visual reporter upgrade: React 18 → 19 (replaces Dependabot #1264).
Remix 2 accepted only React 18; React Router 7 accepts React 18 and 19. The other UI packages accept React 19 (
react-select5.10:^16.8 || … || ^19.0,react-icons5.7:*).These are development dependencies of the reporter: they build the static report UI. Users do not install them.
Changes
react,react-dom,@types/react,@types/react-dom: 18 → 19.3.app/types/index.ts: with@types/react19,useRef<T>(null)returnsRefObject<T | null>, soCanvasDrawingProps.canvasRefallowsnull. The drawing hook already checkscanvasRef.currentfornull.Test
react-selectfilters work: the Status dropdown opens with "All", "Passed" and "Failed"; "Passed" shows 19 cards and "Failed" 17. No browser console errors.typecheck,pnpm test(1077 unit tests): pass.pnpm peers check: no React peer warning.No changeset: development dependencies only, and the built UI does not change.
🤖 Generated with Claude Code