Visualizer Refactor - #139
Conversation
Switched to time-based visualization so trial-based no longer needed
|
@micahwoodard - I've reimplemented the visualizer with a shader pass rather than OpenCV transformations in PR #162. I was not able to test this on a camera with frame rate >200Hz but it seemed to eliminate latency problems on the hardware I have. Would you be able to test on your rigs? |
|
Yes will try and test this afternoon |
Reimplement Saturation visualizer as a shader pass
micahwoodard
left a comment
There was a problem hiding this comment.
Tested and seems to be working. Once the ignored files are deleted, I believe this can be merged
|
@RoboDoig A few more notes while I was reviewing #164.
I have not played with bonsai-native imgui workflows that much, but out of curiosity why do you bind them with CombineLatest?
Thanks! |
|
@bruno-f-cruz thank you! Re 4. I don't think you're missing anything - I think Zip would indeed be less overhead. As you say this is just to synchronize branches which is necessary for ordering of groups of elements in bonsai imgui. |
|
@bruno-f-cruz @micahwoodard - for rotating the image in shader, is free rotation necessary or is it always done in 90 degree increments? Both possible just much more straightforward for 90 degree increments! |
…ias-visualization Feat autowater and bias visualization
Guards retracted stage movement
Ensure visualizer is automatically visible on workflow start
micahwoodard
left a comment
There was a problem hiding this comment.
I get crashing and memory errors without this take until which is why I added originally.
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at OpenTK.Graphics.OpenGL4.GL.DeleteTextures(Int32 n, Int32& textures) in I:\work\github\opentk\src\OpenTK\Graphics\OpenGL4\GL4.cs:line 16159
|
@RoboDoig I added back the takeuntil to circumvent the AccessViolationException to be able to continue running a mouse for testing today. We can remove and fix with something else though |

This PR refactors the dynamic foraging visualizers to use a full Bonsai ImGui approach according the the requirements outlined in the visualizer refactor milestone
Addresses issues #99, #100, #101, #102, #103, #104, #105.
Individual visualizers take as input an observable source that describes their parent layout group (e.g. tab area, table window) such that visualizers can be reorganised within a parent layout structure. Generally, data is mapped to visualizers by externalized subject names corresponding to the appropriate data source or event.