You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: build the visual reporter with Vite 6 - #1291
First step of the visual reporter upgrade: build the reporter with Vite 6 (5.4 → 6.4).
Remix 2 accepts Vite ^5.1.0 || ^6.0.0, so Vite 6 is possible before the move to React Router. Replaces Dependabot #1267, which changed only package.json and not pnpm-lock.yaml (a frozen install would fail).
Vite is a development dependency of the reporter: it builds the static report UI (build/client), which the CLI copies and serves. Users do not install Vite.
Planned next steps (one PR each)
Remix 2 accepts only React 18, so the order is:
Vite 6 (this PR)
Remix 2 → React Router 7 (accepts React 18/19, Vite 5–8, TypeScript 5/6; also removes the TypeScript 6 peer warning)
The built UI is pixel-identical: the demo report (pnpm build + pnpm script:prepare.report, served with sirv) opened in headless Chrome with WebdriverIO, screenshots of the home view and of the comparison overlay (click on the first snapshot): 0 different pixels between the Vite 5 and the Vite 6 build.
GitHub Pages build (GITHUB_PAGES=/visual-testing/): the asset paths keep the base path.
Reporter typecheck, pnpm test (lint, types, 1077 unit tests): pass.
The build messages are the same as before (the Remix "future flags" notes and a sourcemap note for SelectHeader.tsx, both already there with Vite 5).
No changeset: development dependency only, and the built UI does not change.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of the visual reporter upgrade: build the reporter with Vite 6 (5.4 → 6.4).
Remix 2 accepts Vite
^5.1.0 || ^6.0.0, so Vite 6 is possible before the move to React Router. Replaces Dependabot #1267, which changed onlypackage.jsonand notpnpm-lock.yaml(a frozen install would fail).Vite is a development dependency of the reporter: it builds the static report UI (
build/client), which the CLI copies and serves. Users do not install Vite.Planned next steps (one PR each)
Remix 2 accepts only React 18, so the order is:
vite-tsconfig-paths6 (replaces chore(deps-dev): bump vite from 5.4.21 to 8.3.3 #1263)Test
pnpm build+pnpm script:prepare.report, served withsirv) opened in headless Chrome with WebdriverIO, screenshots of the home view and of the comparison overlay (click on the first snapshot): 0 different pixels between the Vite 5 and the Vite 6 build.GITHUB_PAGES=/visual-testing/): the asset paths keep the base path.typecheck,pnpm test(lint, types, 1077 unit tests): pass.SelectHeader.tsx, both already there with Vite 5).No changeset: development dependency only, and the built UI does not change.
🤖 Generated with Claude Code